Skip to content

ci: run the Docker external-driver conformance on tmachine - #5603

Merged
elezar merged 2 commits into
ai-openshell:mainfrom
elezar:ci/5602-tmachine-external-docker-driver/elezar
Nov 16, 2026
Merged

elezar merged 2 commits into
ai-openshell:mainfrom
elezar:ci/5602-tmachine-external-docker-driver/elezar

Conversation

@elezar

@elezar elezar commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Run the Docker compute driver as an external service against the packaged gateway on tmachine, and use that row to replace docker-external-driver-e2e. The tmachine row exercises the packaged gateway, its service and its TLS setup; the old lane used a driver-free gateway and a driver started from a shell wrapper.

Related Issue

Closes #5602

Changes

  • tmachine: add the openshell_external_driver role, which installs a driver binary and a system service, generates the gateway certificates the driver trusts, waits for its socket, and points the gateway at it through /etc/openshell-test/gateway-overrides.toml.
  • tmachine: the packaged gateway role starts the external driver after the runtime images load and before the gateway, and gateway.env selects it by name. Built-in driver names can't be selected over a socket, so the driver registers as external.
  • tmachine: add the deb-external-docker-driver installer.
  • CI: build-external-drivers builds openshell-driver-docker for x86_64, and prepare-integration-inputs.yml copies it into the tmachine inputs. The new external-drivers input on prepare-integration-inputs.yml and e2e-suites.yml is opt-in because release-dev and release-qualification share those workflows and don't build external drivers.
  • CI: add the ubuntu-docker-rootful + deb-external-docker-driver conformance row, enabled from branch-e2e.yml.
  • Remove docker-external-driver-e2e, e2e:docker:external-driver, the external-driver-binary input of e2e-docker-test.yml, and the external-driver branches of e2e/with-docker-gateway.sh and docker_corporate_proxy.rs. The Podman, VM and Kubernetes external-driver lanes are unchanged.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Run locally on an arm64 host (aarch64 guest):

  • openshell-test-runner run --environment ubuntu-docker-rootful --installer deb-external-docker-driver --family conformance --gateway openshell: 36 of 36 conformance tests passed.
  • mise run license:check, mise run rust:format:check and cargo check --tests for e2e/rust pass. The workflow YAML parses, bash -n e2e/with-docker-gateway.sh passes, and the matrix filter in e2e-suites.yml includes the new row only when external-drivers is true.

Not run: the GitHub Actions workflows themselves (amd64, KVM runners) and the in-process Docker e2e after the with-docker-gateway.sh edit. The conformance suite was intermittently flaky on the local VM (both with and without the external driver), and the runner's SSH step occasionally rejected the guest password right after a layer build; a rerun on the cached layer passed.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Add the openshell_external_driver role and a deb-external-docker-driver
installer. The role installs the driver binary and a system service, generates
the gateway certificates the driver trusts, waits for its socket, and points
the packaged gateway at it through the environment gateway overrides.

The packaged gateway role starts it after the runtime images load and before
the gateway, and selects it by name; a built-in driver's name cannot be
selected over a socket.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Replace the docker-external-driver-e2e lane, which ran the conformance
tests against a driver-free gateway and a driver started from a shell
wrapper, with a tmachine row that installs the packaged gateway and runs
openshell-driver-docker as a service (deb-external-docker-driver).

The release workflows share e2e-suites.yml and
prepare-integration-inputs.yml but do not build external drivers, so the
row and the driver download are opt-in (external-drivers).

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 16, 2026
Comment thread tests/tmachine/config.nix Resolved
@elezar elezar added the test:e2e Requires end-to-end coverage label Nov 16, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/5603 does not exist yet. A maintainer needs to comment /ok to test 282b79696094eaccc5b9462af035e2f64ac5341a to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@elezar
elezar force-pushed the ci/5602-tmachine-external-docker-driver/elezar branch from 282b796 to acff784 Compare November 16, 2026 11:49
@elezar

elezar commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok-to-test acff784

@SDAChess SDAChess added the area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. label Nov 16, 2026
@elezar
elezar added this pull request to the merge queue Nov 16, 2026
Merged via the queue into ai-openshell:main with commit bdb8be3 Nov 16, 2026
266 of 270 checks passed
@elezar
elezar deleted the ci/5602-tmachine-external-docker-driver/elezar branch November 16, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(tests): run the Docker driver as an external service in tmachine conformance

2 participants