Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 2, 2026 14:27
4 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-4117.docs.buildwithfern.com/openshell |
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Podman watcher and admission reconciliation from stopping a newly restarted workload while its companion supervisor is still exited. Lifecycle mutations and destructive reconciliation now share a per-sandbox gate and re-read runtime ownership/state before containment.
Related Issue
Refs #4115 (staged cross-driver standardization; remains open). This PR implements the focused Podman fix authorized directly by the maintainer.
Changes
Testing
mise run pre-commitpasses, including workspace Clippy, formatting, license and repository lint checks; commit hook passed again.cargo test -p openshell-driver-podman: 235 tests pass on current main plus this fix.mise run ci: attempted; host Z3/ext4-tool prerequisites were supplied from existing Nix packages, then the workspace build exhausted host disk while linking SDK/server tests. Full local CI remains unqualified.mise run e2e:podman: entrypoint attempted; host has no Podman CLI. The tmachine comparison above supplies focused live coverage.Controlled live comparison on Fedora 44 tmachine, rootless Podman 5.8.1, SELinux Enforcing: a temporary three-second pause between workload and supervisor start failed with
ContainerExitedwhen the start gate was bypassed; the same pause with the gate reached Ready and exec printedlive-gate-pass. Subsequent genuine supervisor loss still contained the workload. The probe used temporary instrumentation on otherwise current code; instrumentation was removed. Gateway recovery after this forced loss was rejected by phase preconditions and is not claimed here.Checklist