fix(sandbox): replace lifetime exec cap with retry deadlines - #4105
Merged
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-4105.docs.buildwithfern.com/openshell |
caudalosamente-wq
approved these changes
Oct 2, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Long-lived sandboxes stop accepting new execs after 4,096 request IDs. Replace that lifetime cap with a 30-second admission and recovery deadline so fresh execs can continue while expired requests fail without running a command twice.
Related Issue
Closes #4103
Changes
Testing
cargo clippy -p openshell-sandbox-backend -p openshell-sandbox --all-targets -- -D warnings, Rust formatting, andgit diff --check.cargo test -p openshell-sandbox-backend -p openshell-sandbox --lib. Coverage includes 10,000 admitted IDs, expiry and reclamation, delayed first attempts, missing deadlines, clock rollback, and digest-bound deadlines. The real boundary process test also launches and recovers an exec after 4,096 earlier IDs.mise run docspasses with no errors and three warnings.mise run pre-commit) passes, including workspace Clippy, formatting, license, Markdown, Helm, protobuf, Python, and TypeScript checks.Checklist