docs(mxc): add missing demo examples for runbook and mTLS scenario - #3659
Merged
Merged
Conversation
Add three files present in the internal mirror but absent from the Windows branch: - mxc-demo-runbook.md: operator runbook for the MXC demo kit - README-mtls.txt: usage notes for the mTLS scenario - run-mtls-test.ps1: PowerShell test runner for the mTLS scenario These are required by the package-demo.ps1 packager script and are referenced by the mxc-kit documentation. No issue required: mechanical sync of missing demo assets. Signed-off-by: Prashant Khodade <pkhodade@nvidia.com>
pkhodade-NV
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 24, 2026 03:42
shailendra-nv
requested changes
Sep 28, 2026
shailendra-nv
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes for four blocking issues:
- The documented clean mTLS flow cannot start the current MXC driver because it supplies no gateway configuration or wxc-exec path.
- The runner can force-stop an unrelated gateway process.
- The runner overwrites/removes persistent CLI registration and mTLS state without restoring it.
- The runbook targets an obsolete MXC configuration/runtime contract.
Static diff checks and PowerShell parsing passed. The visible GitHub checks are green, but the PR's package-demo validation remains unchecked and there is no Windows x64/ARM64 runtime validation covering these flows.
Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
shailendra-nv
approved these changes
Oct 1, 2026
shailendra-nv
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed at 0e988ad. All four requested changes are addressed: valid mock-backed MXC startup, test-owned process cleanup, isolated CLI state, and a current process_container runbook. The ARM64 required lane passed 5,024 tests with 29 skips; the focused example guards passed 4/4. No remaining actionable findings.
Collaborator
|
/ok |
Collaborator
|
/ok to test 0e988ad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mxcdriver configuration.Related Issue
No issue required — localized repair of missing example assets and their current runtime contract.
Changes
README-mtls.txtwith the mock-backed workflow, state-safety guarantees, and optional binary/output paths.run-mtls-test.ps1to generate a valid schema-v2 MXC configuration, use the in-process mock, isolate persistent state, and avoid terminating unrelated processes.mxc-demo-runbook.mdwith current--driver-config-jsonexamples and document the backend filesystem constraints.tests/mtls_examples.rsto prevent the examples from drifting back to removed fields or unsafe state/process handling.Testing
libz3.dllproducedrun-mtls-test.ps1against the release binariescargo test -p openshell-driver-mxc --test mtls_examples -- --nocaptureexample.com; a focused retry reproduced itmise run pre-commit0xC0000005, and Python 3.14 ARM64 cannot buildgrpcio-toolsbecause MSVC receives both/std:c++17and/std:c11; applicable checks above were rerun independentlyChecklist