Repository navigation
State the pre-2016 default of TARGET_RECOVERY_TIME correctly - #10505
Open
Rudi Bruchez (rudi-bruchez) wants to merge 1 commit into
Open
Rudi Bruchez (rudi-bruchez) wants to merge 1 commit into
Rudi Bruchez (rudi-bruchez) wants to merge 1 commit into
Conversation
Contributor
|
Rudi Bruchez (@rudi-bruchez) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 5642d72: ✅ Validation status: passed
For more details, please refer to the build report. |
Contributor
|
Could you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
The description of target_recovery_time reads: "When greater than 0 (the default for older versions), specifies the upper-bound on the recovery time". The parenthesis attaches "the default for older versions" to "greater than 0", which reads as if older versions defaulted to a positive value. Before SQL Server 2016 the default was 0, meaning automatic checkpoints, as two other pages state:
Evidence
Documentation only: the two pages above agree with each other and contradict this sentence.
Change
Moves the pre-2016 default into its own sentence, worded as in the two pages above, and leaves the definition of a value greater than 0 unchanged.