Repository navigation
Bump Loop and LoopKit: Current Setup, display-unit fixes - #566
Merged
Merged
Conversation
Nutcasey
pushed a commit
to Nutcasey/Loop-1
that referenced
this pull request
Oct 28, 2026
On CI the full export in testExportPartial sometimes runs past the 10 s wait. Its completion handler then fires after tearDown, so its asserts land on whichever test is running and the IUO properties it reads are nil, which crashes the test process. In LoopKit/LoopWorkspace#566's runs 1320 and 1321 the export finished about 18 s in, right after the LoopTests bundle ended. The handlers now only record the error; the checks run after the wait, and the wait is 60 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Loop and LoopKit on
next-devto pick up everything merged since #563.Loop
LoopKit
Decodable. Current Setup uses it to read the experiments each decision ran with; Loop next-dev doesn't build without it.Every other submodule was already at the tip of its branch. Built with the
LoopWorkspacescheme on Xcode 27.1 for the simulator (19 plugins).