Skip to content

Move the dose history annotation and IOB tests from Loop - #18

Merged
ps2 merged 2 commits into
mainfrom
dose-history-tests
Nov 1, 2026
Merged

ps2 merged 2 commits into
mainfrom
dose-history-tests

Conversation

@ps2

@ps2 ps2 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #17. These two commits were pushed to plain-numbers-api after #17 merged, so they missed it.

LoopKit/Loop#2635 removes these tests from Loop, so this should merge before or with it.

  • DoseHistoryTests: the 11 IOB, reservoir normalization and dose split tests from Loop, with their fixtures copied byte for byte. Small test-only helpers (pump event dose, Walsh model, basal schedule expansion) stand in for the LoopKit types.
  • A doc note on the test basal schedule expansion: it matches LoopKit's only for a fixed-offset time zone and a schedule whose first item is at midnight, which covers these fixtures.

All 214 tests pass.

ps2 added 2 commits November 1, 2026 07:59
These test this package's dose annotation and insulin on board, so they
belong here rather than in LoopKit/Loop#2635. They read LoopKit's pump event
dose fixtures through a small test-only loader, with LoopKit's Walsh curve
and daily basal schedule expansion ported for the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant