Repository navigation
Show delivered units for finished basal events - #2671
Merged
Merged
Conversation
The Insulin Delivery row showed the basal rate. It now shows units delivered (deliveredUnits, or programmed units if the pump didn't report them) once the dose is no longer mutable; the rate moves to a Basal Rate row. Fixes #2663
This was referenced Nov 9, 2026
dabear
pushed a commit
to bjorninge-no-personal/LoopPebble
that referenced
this pull request
Nov 9, 2026
LoopKit#2667, LoopKit#2671, LoopKit#2673 and LoopKit#2674. One conflict in AlertManager's retraction: LoopKit#2673's per-alert stop of the in-app alert sound, then the watch plugins hear of the retraction as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Insulin Delivery row in the insulin event details showed the basal rate instead of units. For finished (non-mutable) basal events it now shows delivered units (deliveredUnits, falling back to programmed units), and the rate gets its own Basal Rate row.
Fixes #2663
Simulator (pump + CGM simulators), the same finished 4.9 U/hr temp basal before and after: