Repository navigation
Fill the status bar column and cap the HUD row width on iPhone Duo - #2628
Merged
Merged
Conversation
The next-dev counterpart of the fixes in #2627 that #2606 didn't have. - The status table now extends under the leading and trailing safe areas, as it did before it was hosted in SwiftUI, so the HUD row's grey fills the vertical status bar column beside the time instead of leaving a white box. Cell content still stays within the safe area. - The HUD cell's background matches the HUD view, so the cell is grey where it extends past the HUD. - The HUD row is capped at 500 pt and centered, so on the unfolded Duo it no longer stretches across the display with the CGM pill against the display corner. Every iPhone in portrait is narrower, so phones are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next-dev counterpart of the fixes in #2627 that #2606 didn't have, for the status screen on iPhone Duo's unfolded inner display.
What was wrong
Changes
secondarySystemBackground), so the cell is grey where it extends past the HUD.#2627's third fix, keeping the corner inset after a fold/unfold, isn't needed here: next-dev already sets the inset on every reload, and it stayed at 16 pt through a fold and unfold.
Testing
Built with the LoopWorkspace scheme and run on the iPhone Duo simulator, unfolded, with a simulated day of meals, boluses and temp basals: at launch, after a fold and unfold, and with the muted-alerts banner.
Not checked by screenshot: an iPhone in landscape (charts only), the one layout the wider table could affect.