Repository navigation
Conversation
The loop, pump and CGM HUDs open a screen when tapped, but had no button trait, so VoiceOver read their values without saying they can be activated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop, pump and CGM status HUDs open a screen when tapped, but they had no button trait. VoiceOver read their values ("Pump Status, Add Pump") without announcing that they can be activated. They now get the
.buttontrait where their tap recognizers are added.Checked with AXe on the simulator: the three HUDs now report as buttons.
The related CheckmarkListItem and unset-value fixes are in LoopKit/LoopKit#671.