Repository navigation
Report Guard + Runway in analytics - #2610
Merged
Merged
Conversation
Add it to AnalyticsState alongside the other two experiments: the user property, the algorithm experiment change event and the daily summary. Daily summaries stored before this lack the field and decode it as off.
ps2
added a commit
to ps2/LoopWorkspace
that referenced
this pull request
Oct 25, 2026
- LoopKit/Loop#2609: Algorithm Experiments rows ordered by lift - LoopKit/Loop#2610: Report Guard + Runway in analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2608 added the Guard + Runway experiment but not to analytics, which reported only Integral Retrospective Correction and Glucose Based Partial Application. This adds it everywhere those two appear:
guardAndRunwayin the daily summaryAnalyticsStateis stored in UserDefaults with the daily summary, so it gets a decoder that reads a missingguardAndRunwayas off; otherwise the summary saved before updating would fail to decode and that day's counts would be lost.LoopTests pass (344).