Repository navigation
Simulator notice: start.sh now sets up the ImpossiBLE library - #64
Merged
Merged
Conversation
libre2sim's start.sh sets DYLD_INSERT_LIBRARIES inside the running Simulator, and the other two variables have defaults, so the notice no longer asks for three variables in the scheme. Simulator builds only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libre2sim's start.sh now sets DYLD_INSERT_LIBRARIES inside the running Simulator (booting one if needed), and IMPOSSIBLE_SOCKET and LIBRE2SIM_URL have defaults, so the Simulator-only pairing notice (#62) no longer asks for three scheme variables. Text only, in SimulatorPairingNotice.swift, which is entirely inside #if targetEnvironment(simulator): no change for phones.