Repository navigation
Await alert retractions before asking Loop to delete the manager - #108
Merged
Merged
Conversation
delete() is async: it tears down, awaits each lifecycle alert retraction, then awaits cgmManagerWantsDeletion, so the retractions are guaranteed to land first. The settings view awaits delete() before dismissing.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete()is async. It tears down, awaits each lifecycle alert retraction, then awaitscgmManagerWantsDeletion, so the retractions are guaranteed to land first (LoopKit/LoopKit#675). The settings view awaitsdelete()before dismissing.Tests: the delete tests are async now. The ordering test also asserts that
delete()returns after the delegate. 203 pass.Part of the async device deletion change in LoopKit/LoopKit#685, which this depends on. They merge together.