Repository navigation
Conversation
Dexcom's "???" state (CalibrationState.questionMarks, raw 18) shared the "Sensor is warming up" description with .warmup, so a mid-session sensor glitch was reported as a warm-up. Give it its own string. Fixes Artificial-Pancreas/iAPS#254 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CalibrationState.localizedDescriptiongroups.questionMarks(raw 18, Dexcom's "???" / temporary sensor issue) with.warmup, so a sensor that drops into the ??? state mid-session is described as "Sensor is warming up". This gives state 18 its own description, "Temporary sensor issue", and adds the string toLocalizable.xcstrings(source language only).No behavioural change:
hasReliableGlucosealready returnsfalsefor.questionMarks; only the displayed description differs.Reported against iAPS (Artificial-Pancreas/iAPS#254), which consumes this framework through a fork that tracks
devhere; the fork has the same change (Artificial-Pancreas#7).