Skip to content

Use Magento Sales APIs for email test shipments and credit memos - #1

Draft
jissereitsma wants to merge 2 commits into
mainfrom
copilot/fix-magento-phpstan-job
Draft

jissereitsma wants to merge 2 commits into
mainfrom
copilot/fix-magento-phpstan-job

Conversation

@jissereitsma

@jissereitsma jissereitsma commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

The Magento PHPStan job failed because the resolved QuoteExtended 0.0.2 test trait does not define createShipment() or createCreditmemo().

  • Email integration tests: Replace those missing trait calls with local typed helpers that create and retrieve the entities through Magento’s Sales APIs:
    $shipmentId = $this->om()->get(ShipOrderInterface::class)->execute((int)$order->getEntityId());
    return $this->om()->get(ShipmentRepositoryInterface::class)->get((int)$shipmentId);

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@jissereitsma jissereitsma changed the title [WIP] Fix failing GitHub Actions job Magento PHPStan Use Magento Sales APIs for email test shipments and credit memos Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants