Skip to content

fix(settings): match search against translated card text - #104

Merged
LeanBitLab merged 1 commit into
mainfrom
fix/settings-search-localized
Nov 20, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
fix/settings-search-localized

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Problem

Settings search matched only hardcoded English keywords, so in Russian (or any other app language) typing "событи" or "календар" found nothing.

Changes

  • Search also matches the visible, already translated text of each card (all TextViews, including folded sections). The index is built when a search starts and dropped when it is cleared.
  • Matching is case- and accent-insensitive using the app locale ("evenement" finds "Événement", Turkish I/ı fold correctly).
  • English keywords stay as aliases, so English terms and synonyms still work.

Verification

  • New SettingsSearchTest (Robolectric): Russian text match, English alias in Russian, case/accent folding, clearing restores cards
  • ./gradlew --offline testDebugUnitTest pass, lintDebug no errors

Independent of #103 (branched from main).

Settings search only matched hardcoded English keywords, so searching in any
other app language found nothing. Also match the visible text of each card,
case- and accent-insensitively, keeping the English keywords as aliases.
@LeanBitLab
LeanBitLab merged commit dc1b27f into main Nov 20, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/settings-search-localized branch November 20, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant