Repository navigation
fix(settings): hide section headers from search results and keep the jump highlight readable - #823
Merged
Merged
Conversation
…jump highlight readable The fine-tune section headers (Swipe gestures, Prediction details, ...) did nothing when clicked in the search results, and the settings inside them are listed anyway. The highlight after a long press used a solid primaryContainer behind texts that keep the onSurface color, which was unreadable in some themes; it is a tint of the primary color now.
…setting A card was one list item, so opening a large screen (toolbar, advanced, appearance) composed every setting of it in a single frame. Each setting is its own lazy row now, drawn as one card as before; the jump to a setting scrolls to its row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
primaryContainer, so texts keep their contrast in light and dark themes (it was white on white / dark on dark).Notes
expand_fine_tune_key prefix (all 13 section headers use it).