Repository navigation
chore(badges): show the current pre-release on the button, keep the badge on the stable release - #822
Merged
Merged
Conversation
…adge on the stable release The Get Pre-release button is now generated by update-badges.yml with the latest pre-release version under the title, refreshed after each release build and nightly. docs/badges/download.svg follows the latest stable release only, so the release verifier no longer checks it for betas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Separates the two release badges: the Get Pre-release button now shows the current pre-release version, and the version badge follows the latest stable release only.
Motivation & Context
docs/badges/download.svgis generated nightly from the latest stable release, but the release flow andverify_release_sync.pyrequired it to contain the beta's base version. Each beta bump was reverted by the nightly job, and the verifier failed on every beta. The Get Pre-release button was a static image with no version.Changes Made
update-badges.yml:LeanType_4.3.3-...) plus the beta number in the tag (beta-433-3), shown only while it is newer than the latest stable release;docs/badges/get-pre-release.svg: the same button as before with the version under the title;Build Release APKsworkflow completes, so the button is not a day behind (still nightly).README.md: the Get Pre-release button usesdocs/badges/get-pre-release.svg.docs/badges/download.svg: back tov4.3.2, the latest stable (the v4.3.3-beta3 release commit had bumped it).tools/verify_release_sync.py: the stable badge is only checked for stable versions.Verification & Testing
verify_release_sync.py 4.3.3-beta3 4330passes; for stable4.3.3it still checks the badgeworkflow_runtrigger can only be exercised once this is onmain(run the workflow once withworkflow_dispatchafter merging)Guidelines Checklist