Skip to content

chore(badges): show the current pre-release on the button, keep the badge on the stable release - #822

Merged
LeanBitLab merged 1 commit into
mainfrom
chore/split-release-badges
Nov 15, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
chore/split-release-badges

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Summary of Changes

Separates the two release badges: the Get Pre-release button now shows the current pre-release version, and the version badge follows the latest stable release only.

Motivation & Context

docs/badges/download.svg is generated nightly from the latest stable release, but the release flow and verify_release_sync.py required it to contain the beta's base version. Each beta bump was reverted by the nightly job, and the verifier failed on every beta. The Get Pre-release button was a static image with no version.

Changes Made

  • update-badges.yml:
    • finds the latest pre-release and builds its version from the APK name (LeanType_4.3.3-...) plus the beta number in the tag (beta-433-3), shown only while it is newer than the latest stable release;
    • generates docs/badges/get-pre-release.svg: the same button as before with the version under the title;
    • also runs after the Build Release APKs workflow completes, so the button is not a day behind (still nightly).
  • README.md: the Get Pre-release button uses docs/badges/get-pre-release.svg.
  • docs/badges/download.svg: back to v4.3.2, the latest stable (the v4.3.3-beta3 release commit had bumped it).
  • tools/verify_release_sync.py: the stable badge is only checked for stable versions.

Verification & Testing

  • Ran the workflow's real fetch and generate steps (extracted from the YAML) in a scratch directory against live GitHub data: stable 4.3.2 and the latest pre-release detected, SVGs are valid XML
  • verify_release_sync.py 4.3.3-beta3 4330 passes; for stable 4.3.3 it still checks the badge
  • The new workflow_run trigger can only be exercised once this is on main (run the workflow once with workflow_dispatch after merging)
  • The rendered button is not checked visually in the README

Guidelines Checklist

  • This PR addresses a single focused concern.
  • Does not add unnecessary dependencies or binary blobs.
  • No em dashes used in comments, descriptions, or documentation.

…adge on the stable release

The Get Pre-release button is now generated by update-badges.yml with the
latest pre-release version under the title, refreshed after each release
build and nightly. docs/badges/download.svg follows the latest stable
release only, so the release verifier no longer checks it for betas.
@LeanBitLab
LeanBitLab merged commit b77b961 into main Nov 15, 2026
@LeanBitLab
LeanBitLab deleted the chore/split-release-badges branch November 15, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant