Repository navigation
Add fall back message for custom error messages - #17
Merged
Merged
Conversation
Github also throws `custom` error messages and the switch doesn't catch it. ```[errors] => Array ( [0] => Array ( [code] => custom [resource] => Repository [field] => name [message] => name can't be private. You are over your quota. ) )``` Adding a `default` fixes this.
Contributor
|
Are you sure that error is thrown with code |
Contributor
Author
|
I only found it because I received the following as an exception message: Ie no message.. Why do I need to touch the docs for this? |
stloyd
added a commit
that referenced
this pull request
Nov 2, 2012
Add fall back message for custom error messages
Contributor
|
Merged then! Thanks! About PR for GH API docs, it would allow other people to don't miss that there are also such errors, look that only those what I have implemented are listed here: http://developer.github.com/v3/#client-errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github also throws
customerror messages and the switch doesn't catch it.Adding a
defaultfixes this.