3.0 roadmap #904

Activity

1. acrobat commented on Jul 11, 2020

   

   acrobat

   on Jul 11, 2020

   Last edited by acrobat

   Collaborator

   More actions

   I don't think 3.0 should be long away, but I want to get some work of the. 3.0 milestone done before putting a release out. Most of these issues require some prepwork or deprecations in 2.0.

   Second part would be to check if there are things in 2.0 that should need some cleanup, so we can prepare the changes and have them cleaned in 3.0.
2. GrahamCampbell commented on Jul 11, 2020

   

   GrahamCampbell

   on Jul 11, 2020

   Last edited by GrahamCampbell

   ContributorAuthor

   More actions

   With #554, I think we should have add a perPage method which creates a new instance of the api class with per page set. That way we can avoid the double set hack from the result pager and make the api classes immutable (in that respect). It could also be implemented on 2.x in a BC way (by deprecating ApiInterface and the set/get page methods and adding a fresh interface PageableInterface or something).

   I suppose the 2nd issue to address RE immutability is the configure methods. We could simply make configure return a new instance, rather than modifying the class. In 2.x, it's already marked as returning the class, and in 3.x we could drop the fact that it mutates the original.
3. GrahamCampbell commented on Jul 11, 2020

   

   GrahamCampbell

   on Jul 11, 2020

   ContributorAuthor

   More actions

   Let me know if you like those ideas, or have something different in mind, and I'll get started on a PR.
4. GrahamCampbell commented on Jul 11, 2020

   

   GrahamCampbell

   on Jul 11, 2020

   ContributorAuthor

   More actions

   Maybe it's not worth implementing on 2.x tbh, and a pain to implement safely. On 3.x, we could make the constructor in AbstractApi final, which would allow us to do this:

       /**
        * @param Client   $client
        * @param int|null $perPage
        *
        * @return void
        */
       public final function __construct(Client $client, int $perPage = null)
       {
           if (null !== $perPage && ($perPage < 1 || $perPage > 100)) {
               throw new ValueError(sprintf('%s::perPage(): Argument #2 ($perPage) must be between 1 and 100', self::class));
           }
   
           $this->client = $client;
           $this->perPage = $perPage
       }
   
       /**
        * Create a new instance with the given per page parameter.
        *
        * @param int|null $perPage
        *
        * @return static
        */
       public function perPage(?int $perPage)
       {
           return new static($this->client, $perPage);
       }
5. GrahamCampbell commented on Jul 14, 2020

   

   GrahamCampbell

   on Jul 14, 2020

   ContributorAuthor

   More actions

   That solution won't work, because some API want to have additional input. I have a solution that works though now, and I've implemented it for the GitLab API client https://github.com/GitLabPHP/Client/tree/10.0. I'll PR the same solution here. :)
6. acrobat commented on Jul 16, 2020

   

   acrobat

   on Jul 16, 2020

   Collaborator

   More actions

   Thanks I will checkout the PR! I was checking the current test suite and found some more stuff we need to deprecate for removal in 3.0. I will create issues for these things later
7. GrahamCampbell commented on Jul 16, 2020

   

   GrahamCampbell

   on Jul 16, 2020

   ContributorAuthor

   More actions

   I think the next job for me after pagination is sorted is to remove the configure() stuff. I think that is only used to set accept headers (either to change the content type from json to something else, or to access preview APIs). I think it would be totally reasonable for methods to simple pass an accept header in the headers list when they make a ->get or ->post, etc call. We don't need to over-engineer things. :)
8. acrobat commented on Nov 29, 2020

   

   acrobat

   on Nov 29, 2020

   Collaborator

   More actions

   I'm going to close this one as the only thing I want to get done for 3.0 is #907. Other work will be done in 3.x of prepared for 4.0.
9. acrobat

   closed this as completedon Nov 29, 2020
10. acrobat

    added a commit that references this issue on Dec 9, 2020

    feature #907 [3.x] Re-worked pagination to not mutate the api classes…

    ...

    9b0a7c3