Skip to content

Make sure configure returns $this #549

New issue
New issue
Closed
Closed
Make sure configure returns $this#549
Milestone
Release 2.2

Description

@Nyholm
Nyholm
opened on Mar 26, 2017

We need to make sure all our configure() calls returns $this.

This is blocked by #532

Activity

  1. Nyholm
    added this to the Release 2.2 milestone on Mar 26, 2017

  2. bobeagan commented on Mar 27, 2017

    @bobeagan
    bobeagan
    on Mar 27, 2017
    Contributor

    I believe this should be good, the only configure() that doesn't is in the AbstractApi https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/AbstractApi.php#L37

  3. Nyholm commented on Mar 28, 2017

    @Nyholm
    Nyholm
    on Mar 28, 2017
    CollaboratorAuthor

    Thank you!

  4. Nyholm
    closed this as completedon Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions