Repository navigation
Form Builder: Sign Block Settings - #1284
Merged
n7studios merged 4 commits intoNov 20, 2026
Merged
Conversation
…ther settings can't be changed when submitted
…e' into form-builder-sign-settings
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
November 17, 2026 09:29
n7studios
marked this pull request as ready for review
November 17, 2026 09:29
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
noelherrick
approved these changes
Nov 17, 2026
n7studios
merged commit Nov 20, 2026
2b7162a
into
form-builder-no-subscriber-cookie
349 of 367 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Form, Tag and Sequence IDs, store entries and redirect settings were read from hidden fields that could be changed in the request, allowing a visitor to subscribe any email address to any Form, Tag or Sequence, or redirect to any site.
The block's settings, including its custom field keys, are now signed. Submissions with changed settings, or no signature, are rejected, and only the block's custom fields are sent to Kit.
Testing
testSubscriberNotCreatedWhenBlockSettingsChangedtestSubscriberNotCreatedWhenSignatureMissingtestOnlyBlockCustomFieldsSubscribedtestSubscribeWithRedirectURLChecklist