Skip to content

fix(shell): candidate-tui 缺少 Vim 时快速失败（本地诊断） #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JavaZeroo wants to merge 2 commits into from
Closed

fix(shell): candidate-tui 缺少 Vim 时快速失败（本地诊断） #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0647d54
fix(ci): candidate-tui 缺少 Vim 时快速失败，并在作业中提供固定 Vim
JavaZeroo Oct 31, 2026
91a06bc
revert: 移除 workflow 的 Vim 路径步骤
JavaZeroo Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions experiments/shell/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,21 @@
}


def require_fixed_vim(mode):
"""candidate-tui types a Vim command into the real shell, so Vim must be on PATH.

Without this check a missing Vim surfaces as a 33-second scenario timeout whose
only trace is the shell echoing "not recognized as an internal or external
command"; the requirement itself is documented in
docs/research/joint-conpty-baseline.md and is a failure, not a skippable
optional dependency (docs/research/more-capture-ech.md).
"""
if mode == "candidate-tui" and shutil.which("vim") is None:
raise RuntimeError(
"candidate-tui drives Vim inside the shell but no fixed Vim is on PATH; "
"see docs/research/joint-conpty-baseline.md")


def validate(row, mode):
if mode in WORKSPACE_DATA_MODES:
closed = 3 if mode in ("ui-workspace-save", "ui-workspace-restore") else 0 if mode == "ui-workspace-empty" else 1
Expand Down Expand Up @@ -430,6 +445,7 @@ def close(self, record=None):
def execute(exe, mode, out, timeout=40, settings_source=None, *, resources=False):
if mode in ("ui-paste-system", "ui-clipboard-system", "ui-copy-system", "ui-copy-bytes-system", "ui-copy-context-system", "ui-actions-system"):
require_hosted_clipboard(os.environ)
require_fixed_vim(mode)
if resources and mode != "ui-workflow-sessions":
raise ValueError("resource observation is limited to the bounded sessions workflow")
out.mkdir(parents=True, exist_ok=False)
Expand Down
Loading