Skip to content

docs(research): resize 重绘时序证据与候选方向 (#194) - #197

Merged
JavaZeroo merged 1 commit into
mainfrom
research/repaint-design
Oct 29, 2026
Merged

JavaZeroo merged 1 commit into
mainfrom
research/repaint-design

Conversation

@JavaZeroo

Copy link
Copy Markdown
Owner

为 #194 固化观测与候选方向,不改行为。

  • 记录“重绘按旧几何生成、按新几何消费、错位=高度差”的算术证据(选区诊断 29/29 与 111/111、进度 top 75→78、输出轨迹约 10 次尾部重绘)。
  • 列出三个候选方向(先排空/尺寸世代/识别吸收)及各自风险,并固定实施前必须先做的可行性实验。

Refs #194 #38

… refs #194

Fixes the observed arithmetic (repaint generated for the previous geometry, consumed at the new one, shifted by the height difference), lists three candidate directions with risks, and fixes the bounded experiment that must precede any implementation.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T18:11:57.723668Z 73a5112 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73a5112021

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2. **进度记录**:几何变化前 `grid=[111,7] top=75`,缩放到 75% 时 `grid=[149,10] top=75`,回到 100% 时 `grid=[111,7] top=78`,且 `selected` 由 true 变 false。
3. **输出轨迹**:一轮几何序列里出现约 10 次"回 home 重打尾部 6 行(075–080)"的重绘批次,并带 `ESC[7;1H` 与若干 `ESC[K CR LF`。

把三者合起来:重绘批次按**旧几何**(10 行、首行 075)生成,被**新几何**(7 行、首行 078)消费,于是行 0–5 被写成 075–080,整体错位 **10 − 7 = 3 行**。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the repaint-generation ordering labeled as a hypothesis

The listed observations establish a content change and a three-row displacement, but do not establish that the repaint was generated for the ten-row geometry. In the reviewed code, experiments/shell/shell.cpp records output timestamps and dimensions at consumption, not generation or arrival. Moreover, experiments/shell/results/2026-10-29-resize-repaint-witness/README.md explicitly preserves two distinct interleavings producing the bad state and says the actual CI cut remains unknown. Presenting one ordering as an observed fact here can incorrectly constrain the proposed fix before the timing experiment below has resolved it. Label this explanation as a hypothesis and retain the unresolved generation/arrival/consumption ordering.

AGENTS.md reference: AGENTS.md:L13-L13

Useful? React with 👍 / 👎.

@JavaZeroo
JavaZeroo merged commit 250800c into main Oct 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant