require('xterm-player') leads to window is not defined in node env #12

Activity

1. JavaCS3

   added

   bugSomething isn't workingSomething isn't working

   on Mar 4, 2020
2. JavaCS3

   self-assigned this

   on Mar 4, 2020
3. JavaCS3

   added a commit that references this issue on Mar 4, 2020

   fix window is not defined #12

   52b7965
4. JavaCS3 commented on Mar 4, 2020

   

   JavaCS3

   on Mar 4, 2020

   Last edited by JavaCS3

   OwnerAuthor

   More actions

   In v0.0.8

   > require('xterm-player')
   Thrown:
   ReferenceError: window is not defined
       at Object.<anonymous> (/private/tmp/test/node_modules/xterm/lib/xterm.js:1:224)
       at Module._compile (internal/modules/cjs/loader.js:778:30)
       at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
       at Module.load (internal/modules/cjs/loader.js:653:32)
       at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
       at Function.Module._load (internal/modules/cjs/loader.js:585:3)
       at Module.require (internal/modules/cjs/loader.js:692:17)
       at require (internal/modules/cjs/helpers.js:25:18)
       at webpackUniversalModuleDefinition (/private/tmp/test/node_modules/xterm-player/dist/js/xterm-player.js:3:28)
   

   This should be fixed in xterm.js
   xtermjs/xterm.js#2749