Repository navigation
Conversation
Introduce structured AI agent instructions following Intel's AGENTS spec v4: - AGENTS.md: project context (RNG interface, archetype, structure, source-of-truth) - .github/copilot-instructions.md: agent behavior policy Key guidance: - Preserve numpy.random API compatibility - RNG specifics: BRNG selection, statistical properties - Cython: release GIL for MKL RNG calls (thread-safe) - Local dev: conda env + pip install -e . - Statistical validation required for RNG changes Token budget: 217 words (AGENTS.md) + copilot-instructions Based on mkl_fft pattern
|
Updated PR with a more useful multi-level AGENTS hierarchy (commit b0e4a38):
This keeps instructions concise at root and more actionable in each working directory. |
|
@napetrov RandomState in numpy_random interface aligned to numpy's numpy.random.RandomState, and mkl_random.interfaces.numpy_random is fully aligned to numpy.random namespace (aside from get_state and set_state, which cannot be) patch will also be coming soon otherwise if above comment fixed, LGTM |
jharlow-intel
left a comment
There was a problem hiding this comment.
Thanks for putting this together! The layered AGENTS setup with a Copilot entry point matches what mkl-service and mkl_umath already have, and the guardrails around statistical correctness and numpy.random compatibility are spot on. It predates the meson move, though, so a few things need updating; details inline.
| - **Examples:** `examples/` | ||
|
|
||
| ## Build/runtime basics | ||
| - Build system: `pyproject.toml` + `setup.py` |
There was a problem hiding this comment.
This needs a refresh before merge, since it predates the switch to meson-python: master builds from meson.build and there's no setup.py anymore, so the build-system and source-of-truth lists here and in copilot-instructions.md point agents at the wrong files. The editable install also needs --no-build-isolation with meson-python (mkl-service's AGENTS.md uses python -m pip install --no-deps --no-build-isolation .). While you're in there, .github/AGENTS.md is missing build-with-standard-clang, build_pip, coverity, openssf-scorecard, pre-commit, and zizmor, and src/ no longer has support scripts (Anton's point).
What
Add structured AI agent instructions following Intel's AGENTS spec v4:
AGENTS.md— project context for agents (RNG interface, archetype, structure, source-of-truth mapping).github/copilot-instructions.md— agent behavior policy (precedence, contribution expectations, Intel-specific constraints)Why
Standardizes how AI coding assistants (GitHub Copilot, Claude, etc.) understand and work with this repo, reducing hallucinations and enforcing Intel engineering standards automatically.
Key guidance added
numpy.randomAPI compatibility by defaultwith nogil:) for MKL RNG calls (thread-safe in MKL)__init__.pyconda create -n dev python numpy cython mkl-devel pytest && pip install -e .Token budget
AGENTS.md: 217 words (limit 220)Checklist