Repository navigation
Move patterns from wiki to markdown - #134
Merged
lenucksi merged 6 commits intoMar 27, 2020
Merged
Conversation
Details: - port 3 wiki pages into this repo - remove "Donut:" prefix in README - link one Donut to it's PR - last Donut could not be found in the wiki: [Donut 8: Not Invented Here](https://github.com/InnerSourceCommons/innersourcecommons.org/wiki/Donut-8:-Not-invented-here)
spier
marked this pull request as ready for review
March 21, 2020 12:23
Member
|
Thank you for this contribution, @spier 🎉 I think it makes absolute sense to have all pattern content in one place (e.g. not some in the repo, some in a wiki). So imho this can be merged. I'd like to ask for the advice of our experienced pattern yedi knights first: @NewMexicoKid, @gruetter @StingRayZA was there a reason for not having those patterns in the the repo yet? |
lenucksi
approved these changes
Mar 27, 2020
lenucksi
left a comment
Member
There was a problem hiding this comment.
I compared wiki and commit contents and it appears that it's properly moved. I say this LGTM and hence we should merge this.
Re:
- yes, some filenames are longer. No one died from long filenames yet and we can still rename them later. (my 0,02€)
- delete wiki pages: yes, please after merging this.
- follow up on possible pattern content: sounds good. Could you please transform that into an issue with what you've found such that we can handle this later @spier?
Member
Author
|
Follow-up stories:
|
Contributor
|
Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #132.
What I did:
Suggestions for the reviewer:
.mdadded here to the wiki pages I am linking below, to double check that I did not forget anythingBlock by block, these are the patterns I ported.
Block: "Pattern Drafts (proven, not yet fully reviewed)"
I decided to split this up into two separate pattern files. The original wiki page has some more info than these two markdown files but I did not know what to do with that.
So maybe keep this wiki page around? Not sure.
Block: "Pattern Ideas (not yet proven; brainstormed)"
Block: "Pattern Donuts (needing a solution)".