Skip to content

Markdownlint Action is running twice #267

Open

Description

@spier

I noticed that the markdownlint GitHub Action that we have is running twice on the same PR.
It is mostly a cosmetic problem and it also might be a bit confusing for people.

I know that we could prevent it by limiting the action workflow execution to pushes to master like in this GHA configuration. However that seems to have other undesirable consequences.

I wonder if there is some way to do this?

Example:

See the bottom of #261

Screenshot:

markdownlint-running-twice

Activity

  1. added
    ⚙️ Type - MetaImproving how we collaborate in this repo is the main focus of this issue / PR
    on Jan 4, 2021
  2. spier commented on Jan 4, 2021

    @spier
    MemberAuthor

    hi @nschonni. I filed this issue to keep track of the duplicate Action execution that I am seeing.

    I remember that we had already discussed this elsewhere but I couldn't find that conversation thread anymore. I think your argument for not limiting the execution to master only was something related to enabling contributors to fix issues on a branch, without even having to open a PR, right?

  3. nschonni commented on Jan 5, 2021

    @nschonni
    Contributor

    Yeah, you can look at something like https://github.com/fkirc/skip-duplicate-actions#skip-concurrent-workflow-runs to trim the extra runs

  4. spier commented on Jan 10, 2021

    @spier
    MemberAuthor

    Hmm, I see. Feels a little bit strange to add yet one more Action to skip the extra runs of this Action.

    That's why I was wondering if this is a shortcoming in GitHub Actions itself, or if we are just using it the wrong way.

    It would help me if you could elaborate on the experience from a contributor perspective that you are after. I found the previous comment again where you had mentioned this:

    nschonni
    If you limit this to only pushes to the default branch, you won't get checks on PR branches ahead of time, which leads to churn after opening a PR. The filter can also be useful for jobs that really depend on paths in a particular branch.

    Thanks for your help in understanding this, so that we can then explore wat options we have to solve this.

  5. changed the title [-]Markdownlint running twice[/-] [+]Markdownlint Action is running twice[/+] on Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ⚙️ Type - MetaImproving how we collaborate in this repo is the main focus of this issue / PR

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions