Skip to content

fix(logging): redact credential headers in debug output - #257

Merged
Andris28 merged 1 commit into
mainfrom
fa/redact-credential-headers
Nov 6, 2026
Merged

Andris28 merged 1 commit into
mainfrom
fa/redact-credential-headers

Conversation

@Andris28

@Andris28 Andris28 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

In this commit we fix an issue where if debug logging is enabled,
the SDK core only redacted the Authorization and X-Auth* headers.
Other credential-bearing headers were written to the debug log in clear text.

Signed-off-by: András Felleg <afelleg@gmail.com>
@Andris28
Andris28 requested a review from pyrooka November 3, 2026 12:33

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Andris28
Andris28 merged commit d7558fa into main Nov 6, 2026
21 checks passed
@Andris28
Andris28 deleted the fa/redact-credential-headers branch November 6, 2026 14:10
ibm-devx-sdk pushed a commit that referenced this pull request Nov 6, 2026
## [3.28.2](v3.28.1...v3.28.2) (2026-11-06)

### Bug Fixes

* **logging:** redact credential headers in debug output ([#257](#257)) ([d7558fa](d7558fa))
@ibm-devx-sdk

Copy link
Copy Markdown

🎉 This PR is included in version 3.28.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants