Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #504.
The Files upload example catches the Contacts package's
ApiException, so Files API errors escape its handler. Import the exception fromhubspot.filesand correct the upload error message.The generic GET/POST
api_requestexamples also catch the Contacts exception even though that request path usesrequests. Explain the returnedResponse, callraise_for_status(), and catchRequestExceptionso the examples handle HTTP and transport failures. SDK runtime behavior and generated clients are unchanged.Validation (Python 3.11.15):
make test: 105 passed. Six existing invalid-escape warnings come from generated HubDB files.git diff --check: passed.Live HubSpot integration tests were not run because they require account credentials; the examples were checked with mocked transport and the real SDK exception classes.
AI assistance: Codex helped inspect the request paths, edit the examples, and run these checks.