Repository navigation
fix: serialize dictionary request bodies as JSON - #8
Open
Shubham-Padkonde wants to merge 2 commits into
Open
Shubham-Padkonde wants to merge 2 commits into
Shubham-Padkonde wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README passes a dictionary to
request, but Requests encodes it as form data while the SDK advertisesapplication/json. Nested order objects lose their JSON structure, and an empty dictionary sends no body.Use Requests' JSON serialization for dictionaries. Pre-serialized strings and bytes retain their existing behavior, including the file-based sample.
Validation:
python -m unittest test_oneflow_sdk -qpasses. The tests inspect actual prepared HTTP requests while mocking only the network send: nested and empty dictionaries produce valid JSON, and serialized strings/bytes are unchanged. Both dictionary cases fail before the fix. No live orders were submitted.git diff --checkpasses.After merging the upstream redirect change, both request tests pass across four inputs. Each also checks the value of
allow_redirectsat the network send boundary.