Improve document_migration_upgrades time complexity to remove O(n^2) - #4626
Open
0HyperCube wants to merge 1 commit into
Open
0HyperCube wants to merge 1 commit into
0HyperCube wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
0HyperCube
force-pushed
the
migrate-node-perf
branch
from
September 30, 2026 08:31
6964a23 to
f20b659
Compare
0HyperCube
force-pushed
the
migrate-node-perf
branch
from
October 1, 2026 11:28
f20b659 to
9d5c2ef
Compare
TrueDoctor
approved these changes
Oct 1, 2026
Member
|
!build (Run ID 36877002363) |
Wasm: 40.02 MB — JS: 0.46 MB — CSS: 0.09 MB — Fonts: 0.30 MB — Images: 0.09 MB — All Assets: 40.96 MB |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #4572.
There is seemingly no need to run the migration code to create layer stacks for each node. It can just be done once per document after all nodes are migrated.
This fixes a significant hang of several seconds when loading saved
.graphitewith many layers.