Skip to content

Tests optimization and reliability - #6324

Merged
sosnovsky merged 19 commits into
masterfrom
tests-optimization-live-test
Nov 11, 2026
Merged

sosnovsky merged 19 commits into
masterfrom
tests-optimization-live-test

Conversation

@sosnovsky

@sosnovsky sosnovsky commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

This PR reduces repeated work in CI and the test suite, makes live Gmail tests less timing-sensitive to improve test reliability:

  • build the extension and compile tests in a shared Semaphore job. Reuse the build across test jobs and rebuild locally on a cache miss
  • group related live Gmail scenarios to reuse account and browser setup
  • remove recovery tests already covered by the wrong-passphrase-then-success scenario
  • handle localized Google OAuth confirmation screens and retry stale browser queries within the polling deadline
  • parameterize decryption, sender, and malformed-key cases to remove duplicated code
  • strengthen WKD fallback, key revocation, and PGP armor boundary assertions

no issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • if this PR fixes a security issue: I tried to bypass the new fix, and failed (leave unticked if this PR is not a security fix)
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky changed the title Tests optimization Tests optimization and reliability Oct 26, 2026
@sosnovsky
sosnovsky requested a review from martgil November 10, 2026 13:26
@sosnovsky
sosnovsky marked this pull request as ready for review November 10, 2026 13:26
@sosnovsky

Copy link
Copy Markdown
Collaborator Author

Hi @martgil, this one ready for review, should make our tests faster and more reliable.

Comment thread test/source/tests/unit-browser.ts Resolved
martgil
martgil previously approved these changes Nov 11, 2026

@martgil martgil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

@martgil martgil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky
sosnovsky merged commit 9ba01f1 into master Nov 11, 2026
12 checks passed
@sosnovsky
sosnovsky deleted the tests-optimization-live-test branch November 11, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants