Repository navigation
issue 4348 only send sender email in replyInfoDiv - #4659
Merged
Merged
Conversation
tomholub
commented
Sep 1, 2022
tomholub
marked this pull request as ready for review
September 1, 2022 16:33
Collaborator
Author
|
I'll do a release since this is another hotfix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
replyInfoDivformat. It was sending{email: string, name: string}instead ofstring.close #4656
Tests (delete all except exactly one):
type ReplyInfoRawwhich must remain stable to work with FES UI. With this in place, the original problem would have been noticed and corrected during development or review.To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):