Skip to content

issue 4348 only send sender email in replyInfoDiv - #4659

Merged
tomholub merged 2 commits into
masterfrom
issue-4348-malformed-reply-info-div
Sep 2, 2022
Merged

tomholub merged 2 commits into
masterfrom
issue-4348-malformed-reply-info-div

Conversation

@tomholub

@tomholub tomholub commented Sep 1, 2022 •

Copy link
Copy Markdown
Collaborator

This PR fixes replyInfoDiv format. It was sending {email: string, name: string} instead of string.

close #4656


Tests (delete all except exactly one):

  • I decided not to test this since I'd like to send out update soon and it's not easy to test. I've refactored the code to make it easier to notice this regression in PR code reviews by adding type ReplyInfoRaw which must remain stable to work with FES UI. With this in place, the original problem would have been noticed and corrected during development or review.

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Comment thread test/source/tests/compose.ts Resolved
@tomholub
tomholub marked this pull request as ready for review September 1, 2022 16:33
@tomholub

tomholub commented Sep 2, 2022 •

Copy link
Copy Markdown
Collaborator Author

I'll do a release since this is another hotfix

@tomholub
tomholub merged commit bf2a232 into master Sep 2, 2022
@tomholub
tomholub deleted the issue-4348-malformed-reply-info-div branch September 2, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot reply from FES to password-messages sent from 8.3.3 up

1 participant