Skip to content

Added more domains to getPublicEmailDomains. Refactored code.| #1580 - #1583

Merged
DenBond7 merged 1 commit into
masterfrom
issue_1580_add_more_domains
Nov 26, 2021
Merged

DenBond7 merged 1 commit into
masterfrom
issue_1580_add_more_domains

Conversation

@DenBond7

Copy link
Copy Markdown
Collaborator

This PR Added more domains to getPublicEmailDomains.

close #1580

issue #0000 // if it doesn't close the issue yet


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7
DenBond7 merged commit 11042e3 into master Nov 26, 2021
@DenBond7
DenBond7 deleted the issue_1580_add_more_domains branch November 26, 2021 14:49
const val EMAIL_PROVIDER_GMAIL = "gmail.com"
const val EMAIL_PROVIDER_GOOGLEMAIL = "googlemail.com"
const val EMAIL_PROVIDER_YAHOO = "yahoo.com"
const val EMAIL_PROVIDER_OUTLOOK = "outlook.com"

@IvanPizhenko IvanPizhenko Nov 26, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add more:
hotmail.com
yahoo.co.uk
yandex.com[ru, ua, kz, by]
mail.ru (also inbox.ru, list.ru bk.ru mail.ua internet.ru)
rambler.ru (+ lenta.ru autoramber.ru myrambler.ru ro.ru rambler.ua)
ukr.net
meta.ua
i.ua (+ ua.fm email.ua 3g.ua football.ua)
bigmir.net
wp.pl
onet.pl
any known free email services in CZ and SK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more domains to getPublicEmailDomains

3 participants