Skip to content

Improved EmailUtil.getDomain().| #1581 - #1582

Merged
IvanPizhenko merged 2 commits into
masterfrom
issue_1581_improve_get_domain_method
Nov 27, 2021
Merged

IvanPizhenko merged 2 commits into
masterfrom
issue_1581_improve_get_domain_method

Conversation

@DenBond7

Copy link
Copy Markdown
Collaborator

This PR Improved EmailUtil.getDomain()

close #1581


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

tomholub
tomholub previously approved these changes Nov 26, 2021
IvanPizhenko
IvanPizhenko previously approved these changes Nov 26, 2021
@IvanPizhenko

Copy link
Copy Markdown
Contributor

@DenBond7 "Instrumentation tests with email server" fails here, please have a look.

@DenBond7
DenBond7 dismissed stale reviews from IvanPizhenko and tomholub via af23932 November 27, 2021 15:44
@IvanPizhenko
IvanPizhenko merged commit 110a862 into master Nov 27, 2021
@IvanPizhenko
IvanPizhenko deleted the issue_1581_improve_get_domain_method branch November 27, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve EmailUtil.getDomain()

3 participants