Skip to content

issue #1074 Introduce project specific code formatting settings - #1077

Merged
tomholub merged 3 commits into
masterfrom
ip-1074-formatting-settings
Mar 12, 2021
Merged

tomholub merged 3 commits into
masterfrom
ip-1074-formatting-settings

Conversation

@IvanPizhenko

Copy link
Copy Markdown
Contributor

This PR formatting settings as described by the @DenBond7 right into the IntelliJ project.

@IvanPizhenko

Copy link
Copy Markdown
Contributor Author

@DenBond7 Semaphore fails, likely due to some timeout

com.flowcrypt.email.ui.activity.ImportPrivateKeyActivityFromSettingsTest > testImportKeyFromBackup[ci-test-pixel-x86-api30(AVD) - 11] FAILED 24:19
        java.lang.RuntimeException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root: 24:19
        Root{application-window-token=android.view.ViewRootImpl$W@4804303, window-token=android.view.ViewRootImpl$W@4804303, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} ty=BASE_APPLICATION wanim=0x10302fe

Please take a look.
I have already restarted semaphore few times and all times it failed on the one of the "Instrumentation tests" - each time on different one. Sometimes few instrumentation tests stopped in the middle. Maybe something can be done about this? Like increasing some timeouts.

@IvanPizhenko

IvanPizhenko commented Mar 12, 2021 •

Copy link
Copy Markdown
Contributor Author

trying to re-run semaphore once again...

@IvanPizhenko

Copy link
Copy Markdown
Contributor Author

Increased test execution time limit by 10 minutes

@tomholub tomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this. If something is wrong, @DenBond7 let me know. I'll also rely on your code reviews in the future before merging. Thanks!

@tomholub
tomholub merged commit e658951 into master Mar 12, 2021
@DenBond7

Copy link
Copy Markdown
Collaborator

@tomholub

If something is wrong, @DenBond7 let me know.

All looks good. @IvanPizhenko Thanks for a good job.

@IvanPizhenko
IvanPizhenko deleted the ip-1074-formatting-settings branch March 12, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants