Skip to content

ignore "registered" json value from "account/login" endpoint #868

Closed

Description

@tomholub

I want to deprecate it, let's start ignoring it.

It always returns true anyway.

Activity

  1. added this to the soon milestone on Mar 29, 2020
  2. tomholub commented on Mar 20, 2021

    @tomholub
    CollaboratorAuthor

    This is a tiny issue where we want to stop expecting a property called registered that we currently return from backend API server endpoint at account/login. Just need to remove it from response models so that eventually I can stop returning it from API itself.

    I'm assigning to @IvanPizhenko since it's a tiny enough issue that he may not need much context about the Android app in general.

  3. modified the milestones: soon, 1.1.6 on Mar 20, 2021
  4. added a commit that references this issue on Mar 20, 2021
  5. IvanPizhenko commented on Mar 20, 2021

    @IvanPizhenko
    Contributor

    Hmm. What I see now is that it reads and writes it from "parcel". Should this remain as is or we can modify how LoginResponse is written and read to/from parcel by excluding this field? Will this break compatibility with existing server or something?

  6. added
    in progresswork on the issue is in progress
    PR submittedPR is submitted for this issue
    and removed
    in progresswork on the issue is in progress
    on Mar 20, 2021
  7. DenBond7 commented on Mar 22, 2021

    @DenBond7
    Collaborator

    close via #1102

  8. tomholub commented on Mar 22, 2021

    @tomholub
    CollaboratorAuthor

    Hmm. What I see now is that it reads and writes it from "parcel". Should this remain as is or we can modify how LoginResponse is written and read to/from parcel by excluding this field? Will this break compatibility with existing server or something?

    @DenBond7 is there generally any risk editing parcels? do they get stored in the app in between version updates?

  9. DenBond7 commented on Mar 22, 2021

    @DenBond7
    Collaborator

    @tomholub

    is there generally any risk editing parcels?

    Of course. If you do it wrongly, you will get a runtime error.

    do they get stored in the app in between version updates?

    No, it is used only at runtime.

    Anyway, don't worry about that. We have JUnit test ParcelableTest that helps us to test all Parcelable implementation over the app. If some class that implements Parcelable will be broken we will know about that before a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

PR submittedPR is submitted for this issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions