You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ignore "registered" json value from "account/login" endpoint #868
This is a tiny issue where we want to stop expecting a property called registered that we currently return from backend API server endpoint at account/login. Just need to remove it from response models so that eventually I can stop returning it from API itself.
I'm assigning to @IvanPizhenko since it's a tiny enough issue that he may not need much context about the Android app in general.
Hmm. What I see now is that it reads and writes it from "parcel". Should this remain as is or we can modify how LoginResponse is written and read to/from parcel by excluding this field? Will this break compatibility with existing server or something?
Hmm. What I see now is that it reads and writes it from "parcel". Should this remain as is or we can modify how LoginResponse is written and read to/from parcel by excluding this field? Will this break compatibility with existing server or something?
@DenBond7 is there generally any risk editing parcels? do they get stored in the app in between version updates?
Of course. If you do it wrongly, you will get a runtime error.
do they get stored in the app in between version updates?
No, it is used only at runtime.
Anyway, don't worry about that. We have JUnit test ParcelableTest that helps us to test all Parcelable implementation over the app. If some class that implements Parcelable will be broken we will know about that before a new release.
Activity
tomholub commentedon Mar 20, 2021
This is a tiny issue where we want to stop expecting a property called
registeredthat we currently return from backend API server endpoint ataccount/login. Just need to remove it from response models so that eventually I can stop returning it from API itself.I'm assigning to @IvanPizhenko since it's a tiny enough issue that he may not need much context about the Android app in general.
issue #868 dismiss registered field
IvanPizhenko commentedon Mar 20, 2021
Hmm. What I see now is that it reads and writes it from "parcel". Should this remain as is or we can modify how LoginResponse is written and read to/from parcel by excluding this field? Will this break compatibility with existing server or something?
Fixed tests compilation.| #868
Modified some strings. Removed unused code.| #868
issue #868 dismiss registered field (#1102)
DenBond7 commentedon Mar 22, 2021
close via #1102
tomholub commentedon Mar 22, 2021
@DenBond7 is there generally any risk editing parcels? do they get stored in the app in between version updates?
DenBond7 commentedon Mar 22, 2021
@tomholub
Of course. If you do it wrongly, you will get a runtime error.
No, it is used only at runtime.
Anyway, don't worry about that. We have JUnit test ParcelableTest that helps us to test all
Parcelableimplementation over the app. If some class that implements Parcelable will be broken we will know about that before a new release.