You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
all differences between enterprise and consumer build #2123
Broadly speaking, consumer version does not know if FES is supposed to be running on the domain or not. Maybe it is, maybe it isn't. During setup, it will try if FES runs there, and if it gets back nothing or errors, it's willing to proceed with regular flow.
On enterprise, the FES MUST be running there, and the only way to proceed with regular flow is if that address returns a 404.
privatefuncontinueBasedOnFlavorSettings() {
if (BuildConfig.FLAVOR==Constants.FLAVOR_NAME_ENTERPRISE) {
/* here we actually need to decide if we should show error or proceed with regular setup flow based on exact customers that will skip to regular setup flow, and the rest will be shown error.*/
continueWithRegularFlow()
} else {
continueWithRegularFlow()
}
}
Activity
DenBond7 commentedon Jan 5, 2023
com.flowcrypt.emailcom.flowcrypt.email.enterprisefalsetruemsauth://com.flowcrypt.email/gVgrJ%2BnS3FFmy0N1RePwMwAKI70%3Dmsauth://com.flowcrypt.email.enterprise/gVgrJ%2BnS3FFmy0N1RePwMwAKI70%3DcontinueWithRegularFlow()showDialogWithRetryButtonRESTRICT_ANDROID_ATTACHMENT_HANDLINGusing Content app(com.airwatch.contentlocker, RESTRICT_ANDROID_ATTACHMENT_HANDLING)not supportedenabledtruefalseEdit_1. Updated
Preview attachmentssectionDenBond7 commentedon Jan 5, 2023
@tomholub @martgil @sosnovsky I hope it's a full list :) I have not found more differences.
tomholub commentedon Jan 5, 2023
This should be supported on both. Whenever EKM is present
tomholub commentedon Jan 5, 2023
This should be enabled on both going forward, as discussed (just mentioning for clarity)
tomholub commentedon Jan 5, 2023
This should apply to more than just SSL error.
Broadly speaking,
consumerversion does not know if FES is supposed to be running on the domain or not. Maybe it is, maybe it isn't. During setup, it will try if FES runs there, and if it gets back nothing or errors, it's willing to proceed with regular flow.On
enterprise, the FES MUST be running there, and the only way to proceed with regular flow is if that address returns a 404.tomholub commentedon Jan 5, 2023
I think there should probably be no difference between consumer and enterprise here.
If
RESTRICT_ANDROID_ATTACHMENT_HANDLINGis present, apply restrictions, else don't apply restrictions, regardless of build.We can file a separate issue for this to discuss the behavior in more detail.
DenBond7 commentedon Jan 5, 2023
I was wrong, it works for both. I've checked. If
clientConfiguration?.usesKeyManager() == truewe try to refresh private keys from EKM.DenBond7 commentedon Jan 5, 2023
Yup. Because #2122 is not completed yet I've added this info to the table.
DenBond7 commentedon Jan 5, 2023
@tomholub I've rechecked (code and ref #1202 (comment)). We have the following situation for Android now.
continueBasedOnFlavorSettings()"enterprise-server" == service.continueBasedOnFlavorSettings()continueBasedOnFlavorSettings()continueBasedOnFlavorSettings()flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/fragment/MainSignInFragment.kt
Line 598 in cfa872b
tomholub commentedon Jan 5, 2023
Ok, I remember this situation. Let's standardize it, as follows.
I believe this will make it the same as my table above. If if doesn't, let me know.
DenBond7 commentedon Jan 7, 2023
Yes. It should work the same.
DenBond7 commentedon Jan 7, 2023
I'm closing it for now. We've opened separate issues for some of the questions.