Skip to content

debug / fix sending web portal message so that it can be replied online #1636

Closed

Description

@tomholub
  • send a message from Android app through FES
  • open the received link on the other account, enter password. Make sure the message opens on fes.flowcrypt.com/...
  • click reply on fes.flowcrypt.com/...
  1. send a message from Android app through FES - works
  2. open the received link on the other account, enter password. Make sure the message opens on fes.flowcrypt.com/...- works
  3. click reply on fes.flowcrypt.com/...- I don't see reply button for a message that was send from Android. But I see this button for the web realization

It seems I have bug on my side. Can we debug this case?

@tomholub Please let me know what info I should provide.

Originally posted by @DenBond7 in #1629 (comment)

@DenBond I'm filing it as a separate issue. Likely a problem with encoding of reply info div.

Activity

  1. tomholub commented on Jan 4, 2022

    @tomholub
    CollaboratorAuthor

    You you could send one message from browser extension and one from android, then download back the armored message from FES for each one of them and decrypt them. Then compare the difference in the contents.

  2. tomholub commented on Jan 4, 2022

    @tomholub
    CollaboratorAuthor

    Here is the infodiv content on browser:

          const infoDiv = Ui.e('div', {
            'style': 'display: none;',
            'class': 'cryptup_reply',
            'cryptup-data': Str.htmlAttrEncode({
              sender: newMsgData.from,
              recipient: Value.arr.withoutVal(Value.arr.withoutVal(recipients, newMsgData.from), this.acctEmail),
              subject: newMsgData.subject,
              token: response.replyToken,
            })
          });

    Contains sender, recipient (array), subject, token. Is that what you are encoding as well? I think I've seen something else.

  3. self-assigned this
    on Jan 5, 2022
  4. DenBond7 commented on Jan 5, 2022

    @DenBond7
    Collaborator

    It's strange. I can't decrypt a message from the web version via gpg nor PGPainless

    https://flowcrypt.com/RtXpbqBxr0
    qwerty1234

    image

    image

    But can decrypt a message from Android

    https://fes.flowcrypt.com/message/6c13d405-c984-4175-b395-2cdbfda42c64
    qwerty1234

    image

    image

  5. DenBond7 commented on Jan 5, 2022

    @DenBond7
    Collaborator

    Btw, web version and PGPainless produce a different password-protected message

    PGPainless
    image

    web
    image

    To have more details I need to have not expired key for den@flowcrypt.com. Then I can provide examples for the same key

  6. github-actions commented on Jan 5, 2022

    @github-actions

    There were 1 email addresses found in the above comment. Please:

    1. Click three dots -> edit to remove the email addresses.
    2. Click edited in the comment header, and click on the previous revision of the comment.
    3. When viewing the old revision with an email in it, click options -> delete this revision from history.
  7. tomholub commented on Jan 5, 2022

    @tomholub
    CollaboratorAuthor

    Yes, because you are comparing legacy flowcrypt.com api (browser extension) to FES API (Android).

    I'll update your keys so you can do the same on your flowcrypt account on browser extension. Then you can compare.

  8. tomholub commented on Jan 5, 2022

    @tomholub
    CollaboratorAuthor

    Updated your key on EAP - you should be now able to test from flowcrypt.com account on browser extension (after resetting it).

    The password-encryption algorithm has changed between original flowcrypt.com/api (used on non-FES accounts on browser extension) and FES API (used for customers that run FES, plus flowcrypt.com accounts). Thus the difference.

  9. DenBond7 commented on Jan 5, 2022

    @DenBond7
    Collaborator

    Thank you! I will try it soon

  10. DenBond7 commented on Jan 6, 2022

    @DenBond7
    Collaborator

    Fixed
    image

  11. added a commit that references this issue on Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions