Skip to content

UI for password encrypted message functionality #1620

Closed

Description

Activity

  1. self-assigned this
    on Dec 21, 2021
  2. DenBond7 commented on Dec 21, 2021

    @DenBond7
    CollaboratorAuthor

    Actually, it's an interesting issue :). It seems we have a not simple logic here.

  3. DenBond7 commented on Dec 21, 2021

    @DenBond7
    CollaboratorAuthor

    Before starting to work on this issue need to understand what exactly we do here.

    As I understand we have the following:

    1. During creating a new encrypted message we can have recipients that don't have public keys.
    2. We show a hint for a user: you can import missing public keys or protect the current message with a pass phrase for recipients with missing public keys.
    3. After that the user should provide missing public keys or a pass phrase that will be used for a password encrypted message.
    4. Let's imagine the user has provided a pass phrase. What do we do next?
    5. It seems we should create an encrypted message that will be sent as attachment, do all things from prepare API model / client class for sending through web portal #1615, receive some URL and send a message with text
    user@flowcrypt.test has sent you a password-encrypted email Click here to Open Message
    
    Alternatively copy and paste the following link: https://flowcrypt.com/HoHoHoHo
    

    and attachments(noname, encryped.asc)

    Just a simplified version what I see.

    @tomholub Please correct me if needed

  4. IvanPizhenko commented on Dec 21, 2021

    @IvanPizhenko
    Contributor

    We also should take into account that enterprise customers may have their own FES instance.

  5. DenBond7 commented on Dec 21, 2021

    @DenBond7
    CollaboratorAuthor

    We also should take into account that enterprise customers may have their own FES instance.

    Yes, it relates to #1621 and #1622

  6. DenBond7 commented on Dec 21, 2021

    @DenBond7
    CollaboratorAuthor

    as an example to discuss

    image

  7. tomholub commented on Dec 21, 2021

    @tomholub
    Collaborator

    I wanted to do this on one platform first (iOS in this case) so that we can see it in action and settle the exact UI before doing it on a second platform (Android). That's why I tried to assign you non-ui tasks here and assign Roman UI tasks there, so I don't have to be potentially wrong twice per platform for all tasks (because I'm not too sure until I see it).

  8. tomholub commented on Dec 21, 2021

    @tomholub
    Collaborator

    We show a hint for a user: you can import missing public keys or protect the current message with a pass phrase for recipients with missing public keys.

    we call it a password in this case to differentiate, though it's true it doesn't sound that different

  9. tomholub commented on Dec 21, 2021

    @tomholub
    Collaborator

    Let's imagine the user has provided a pass phrase. What do we do next?
    It seems we should create an encrypted message that will be sent as attachment, do all things from prepare API model / client class for sending through web portal #1615, receive some URL and send a message with text

    This is outside of scope of this issue, so we don't have to discuss it in detail yet. But basically

    1. call FES to get a reply token
    2. encode the reply token into the message & encrypt a message with both public keys (my own + recipients if any) and the provided password
    3. upload the message to FES
    4. format the message with the sentence + link + encrypted data in attachment
    5. send message formatted this way through gmail
  10. tomholub commented on Dec 21, 2021

    @tomholub
    Collaborator

    This is pretty good. The only problem is, it only shows after user already tapped send which is a bit too late. It would be better to have some banner.

    Also:

    • the password option should be first, when available
    • switch to standard email should be removed when FES available

    image

  11. tomholub commented on Dec 21, 2021

    @tomholub
    Collaborator

    @sosnovsky you can have a look at the sketches above in case it helps you with FlowCrypt/flowcrypt-ios#1221

  12. sosnovsky commented on Dec 21, 2021

    @sosnovsky
    Collaborator

    @sosnovsky you can have a look at the sketches above in case it helps you with FlowCrypt/flowcrypt-ios#1221

    Looks good, I currently have more basic UI implementation:

    Simulator Screen Shot - iPhone 13 - 2021-12-21 at 23 14 59

    Simulator Screen Shot - iPhone 13 - 2021-12-21 at 23 15 04

    Simulator Screen Shot - iPhone 13 - 2021-12-21 at 23 15 15

  13. tomholub commented on Dec 21, 2021

    @tomholub
    Collaborator

    I think the screenshots on both platforms are appropriate (for the level of implementation / features already available for that platform). So it looks on a good track.

    I think on iOS, above the password, we could add another paragraph of text about the user being responsible to share the password. Per the Android screenshot "You are responsible ..."

  14. 28 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions