You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
UI for password encrypted message functionality #1620
Before starting to work on this issue need to understand what exactly we do here.
As I understand we have the following:
During creating a new encrypted message we can have recipients that don't have public keys.
We show a hint for a user: you can import missing public keys or protect the current message with a pass phrase for recipients with missing public keys.
After that the user should provide missing public keys or a pass phrase that will be used for a password encrypted message.
Let's imagine the user has provided a pass phrase. What do we do next?
user@flowcrypt.test has sent you a password-encrypted email Click here to Open Message
Alternatively copy and paste the following link: https://flowcrypt.com/HoHoHoHo
I wanted to do this on one platform first (iOS in this case) so that we can see it in action and settle the exact UI before doing it on a second platform (Android). That's why I tried to assign you non-ui tasks here and assign Roman UI tasks there, so I don't have to be potentially wrong twice per platform for all tasks (because I'm not too sure until I see it).
We show a hint for a user: you can import missing public keys or protect the current message with a pass phrase for recipients with missing public keys.
we call it a password in this case to differentiate, though it's true it doesn't sound that different
Let's imagine the user has provided a pass phrase. What do we do next?
It seems we should create an encrypted message that will be sent as attachment, do all things from prepare API model / client class for sending through web portal #1615, receive some URL and send a message with text
This is outside of scope of this issue, so we don't have to discuss it in detail yet. But basically
call FES to get a reply token
encode the reply token into the message & encrypt a message with both public keys (my own + recipients if any) and the provided password
upload the message to FES
format the message with the sentence + link + encrypted data in attachment
This is pretty good. The only problem is, it only shows after user already tapped send which is a bit too late. It would be better to have some banner.
Also:
the password option should be first, when available
switch to standard email should be removed when FES available
I think the screenshots on both platforms are appropriate (for the level of implementation / features already available for that platform). So it looks on a good track.
I think on iOS, above the password, we could add another paragraph of text about the user being responsible to share the password. Per the Android screenshot "You are responsible ..."
Activity
DenBond7 commentedon Dec 21, 2021
Actually, it's an interesting issue :). It seems we have a not simple logic here.
DenBond7 commentedon Dec 21, 2021
Before starting to work on this issue need to understand what exactly we do here.
As I understand we have the following:
and attachments(
noname,encryped.asc)Just a simplified version what I see.
@tomholub Please correct me if needed
IvanPizhenko commentedon Dec 21, 2021
We also should take into account that enterprise customers may have their own FES instance.
DenBond7 commentedon Dec 21, 2021
Yes, it relates to #1621 and #1622
DenBond7 commentedon Dec 21, 2021
as an example to discuss
Moved CreateMessageFragment to fragment package.| #1620
tomholub commentedon Dec 21, 2021
I wanted to do this on one platform first (iOS in this case) so that we can see it in action and settle the exact UI before doing it on a second platform (Android). That's why I tried to assign you non-ui tasks here and assign Roman UI tasks there, so I don't have to be potentially wrong twice per platform for all tasks (because I'm not too sure until I see it).
tomholub commentedon Dec 21, 2021
we call it a password in this case to differentiate, though it's true it doesn't sound that different
tomholub commentedon Dec 21, 2021
This is outside of scope of this issue, so we don't have to discuss it in detail yet. But basically
tomholub commentedon Dec 21, 2021
This is pretty good. The only problem is, it only shows after user already tapped send which is a bit too late. It would be better to have some banner.
Also:
tomholub commentedon Dec 21, 2021
@sosnovsky you can have a look at the sketches above in case it helps you with FlowCrypt/flowcrypt-ios#1221
sosnovsky commentedon Dec 21, 2021
Looks good, I currently have more basic UI implementation:
tomholub commentedon Dec 21, 2021
I think the screenshots on both platforms are appropriate (for the level of implementation / features already available for that platform). So it looks on a good track.
I think on iOS, above the password, we could add another paragraph of text about the user being responsible to share the password. Per the Android screenshot "You are responsible ..."
28 remaining items
Fixed some more bugs.| #1620
Reverted back some changes in CheckPassphraseStrengthFragment. Refact…
Added missing russian translation.| #1620
Fix translation.| #1620
Simplified some code.| #1620
Fixed lint warnings.| #1620
Fixed russian translation.| #1620
Fixed some existing tests.| #1620
Fixed CheckPassphraseStrengthFragmentTest.| #1620
Added CreateMessageFragmentPasswordProtectedTest.| #1620
Modifed logic in BetterInternetAddressTest to fix tests that use "loc…
Fixed "com.project.starter:easylauncher" usage.| #1620
Modified tests. Fixed rules ordering. Refactored code.| #1620
Issue 1620 UI for send password encrypted msg (#1649)