Skip to content

Kotlin decryption. don't break message render view when a public key is not valid #1348

Closed

Description

Activity

  1. added this to the 1.2.1 milestone on Jul 21, 2021
  2. self-assigned this
    on Jul 21, 2021
  3. tomholub commented on Jul 21, 2021

    @tomholub
    Collaborator

    There are probably two issues here.

    One, when any error happens parsing the public key, it should only affect the rendering of pubkey block, but still render the rest of the message normally.

    Two, this looks like some incompatibility between OpenPGP.js and PGPainless that could probably be addressed in PGPainless.

  4. DenBond7 commented on Jul 21, 2021

    @DenBond7
    CollaboratorAuthor

    One, when any error happens parsing the public key, it should only affect the rendering of pubkey block, but still render the rest of the message normally.

    I think so

  5. DenBond7 commented on Jul 22, 2021

    @DenBond7
    CollaboratorAuthor

    image

  6. tomholub commented on Jul 22, 2021

    @tomholub
    Collaborator

    @DenBond7 I think PGPainless rejected the public key correctly. So the only task here is to make sure that when parsing of public keys fails or they fail verification, it does not affect the whole rendering.

    In this case, best would be to render everything as it was on the left, but in stead of the public key part, add a red box with This message contained a Public Key that was not valid:\n\n${e::class.name}: ${e.message}

  7. changed the title [-]KeyRingInfo.getPrimaryKeyExpirationDate() == "No suitable signatures found on the key."[/-] [+]don't break message render view when a public key is not valid[/+] on Jul 22, 2021
  8. changed the title [-]don't break message render view when a public key is not valid[/-] [+]Kotlin decryption. don't break message render view when a public key is not valid[/+] on Sep 17, 2021
  9. DenBond7 commented on Sep 20, 2021

    @DenBond7
    CollaboratorAuthor

    In this case, best would be to render everything as it was on the left, but in stead of the public key part, add a red box with This message contained a Public Key that was not valid:\n\n${e::class.name}: ${e.message}

    I will show something like this one

    Selection_840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions