You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Kotlin decryption. don't break message render view when a public key is not valid #1348
One, when any error happens parsing the public key, it should only affect the rendering of pubkey block, but still render the rest of the message normally.
Two, this looks like some incompatibility between OpenPGP.js and PGPainless that could probably be addressed in PGPainless.
One, when any error happens parsing the public key, it should only affect the rendering of pubkey block, but still render the rest of the message normally.
@DenBond7 I think PGPainless rejected the public key correctly. So the only task here is to make sure that when parsing of public keys fails or they fail verification, it does not affect the whole rendering.
In this case, best would be to render everything as it was on the left, but in stead of the public key part, add a red box with This message contained a Public Key that was not valid:\n\n${e::class.name}: ${e.message}
changed the title [-]KeyRingInfo.getPrimaryKeyExpirationDate() == "No suitable signatures found on the key."[/-][+]don't break message render view when a public key is not valid[/+]on Jul 22, 2021
changed the title [-]don't break message render view when a public key is not valid[/-][+]Kotlin decryption. don't break message render view when a public key is not valid[/+]on Sep 17, 2021
In this case, best would be to render everything as it was on the left, but in stead of the public key part, add a red box with This message contained a Public Key that was not valid:\n\n${e::class.name}: ${e.message}
Activity
tomholub commentedon Jul 21, 2021
There are probably two issues here.
One, when any error happens parsing the public key, it should only affect the rendering of pubkey block, but still render the rest of the message normally.
Two, this looks like some incompatibility between OpenPGP.js and PGPainless that could probably be addressed in PGPainless.
DenBond7 commentedon Jul 21, 2021
I think so
DenBond7 commentedon Jul 22, 2021
tomholub commentedon Jul 22, 2021
@DenBond7 I think PGPainless rejected the public key correctly. So the only task here is to make sure that when parsing of public keys fails or they fail verification, it does not affect the whole rendering.
In this case, best would be to render everything as it was on the left, but in stead of the public key part, add a red box with
This message contained a Public Key that was not valid:\n\n${e::class.name}: ${e.message}[-]KeyRingInfo.getPrimaryKeyExpirationDate() == "No suitable signatures found on the key."[/-][+]don't break message render view when a public key is not valid[/+][-]don't break message render view when a public key is not valid[/-][+]Kotlin decryption. don't break message render view when a public key is not valid[/+]DenBond7 commentedon Sep 20, 2021
I will show something like this one
Improved showing parse pub keys errors.| #1348
Issue 1101 use pgpainless for msg decryption (#1420)