Skip to content

ci(crate-gate): run monocrate check via uv --script (fix soldr build failure) - #563

Merged
zackees merged 1 commit into
mainfrom
fix/crate-gate-uv-script
Jun 13, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/crate-gate-uv-script

Conversation

@zackees

@zackees zackees commented Jun 13, 2026 •

Copy link
Copy Markdown
Member

Summary

The Crate Gate workflow added in #561 fails on every PR with ERROR: soldr is required to build fbuild from source. Root cause: uv run python ci/check_workspace_crates.py makes uv build the fbuild editable package before running, and that build backend requires soldr, which isn't installed in the crate-gate job.

ci/check_workspace_crates.py is a standalone PEP-723 script (# /// script inline metadata, no third-party deps), so uv run --script runs it in isolation — no project build, no soldr.

Test plan

  • uv run --script ci/check_workspace_crates.py → OK: 14 approved workspace members, no new crates.
  • No project build is triggered (the failing path is avoided entirely)

Regression from #561.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow execution to improve process reliability.

…t build

`uv run python ci/check_workspace_crates.py` makes uv build the `fbuild`
editable package first, which requires `soldr` (not installed in the
crate-gate job) and fails the gate with "soldr is required to build fbuild"
on every PR. The script is a standalone PEP-723 script, so `uv run --script`
runs it in isolation with no project build and no soldr dependency.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ef7c37c2-4294-4778-b565-74d5f6e6054a

📥 Commits

Reviewing files that changed from the base of the PR and between cf1b9c6 and 624564e.

📒 Files selected for processing (1)
  • .github/workflows/crate-gate.yml

📝 Walkthrough

Walkthrough

The crate-gate workflow step is updated to invoke the crate check script via uv run --script instead of uv run python. This change executes the PEP-723 standalone script in isolation, preventing unnecessary attempts to build the fbuild package and avoiding unrelated dependency failures.

Changes

Gate Workflow Script Invocation

Layer / File(s) Summary
Gate script execution via --script flag
.github/workflows/crate-gate.yml
The run command is updated to use uv run --script ci/check_workspace_crates.py instead of uv run python ci/check_workspace_crates.py, with added comments explaining that --script executes the PEP-723 script in isolation to prevent unrelated build failures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A workflow leap, so swift and clean,
--script unlocks what once was unseen,
No builds in sight, dependencies freed,
The gate now runs with all that we need! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: updating the crate-gate workflow to use uv --script for running the monocrate check, and explicitly mentions the fix for the soldr build failure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/crate-gate-uv-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit 224643e into main Jun 13, 2026
91 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 14, 2026
@zackees
zackees deleted the fix/crate-gate-uv-script branch October 16, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant