Skip to content

refactor(build): funnel board resolution through resolution::resolve_board (#519) - #562

Merged
zackees merged 1 commit into
mainfrom
refactor/519-board-resolution-funnel
Jun 13, 2026
Merged

zackees merged 1 commit into
mainfrom
refactor/519-board-resolution-funnel

Conversation

@zackees

@zackees zackees commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

First consolidation step for #519. Adds a single build-side board-resolution funnel so a new resolution input (the next project_dir-style knob) is threaded in one place instead of re-plumbed into each consumer.

Scope is intentionally limited to the fbuild-build build path. The daemon/CLI deploy fallback helpers (from_board_id_or_default, from_board_id_with_override_fallback) live in fbuild-config and already act as shared entry points; folding those in is a separate follow-up under #519.

Test plan

  • soldr cargo test -p fbuild-build --lib resolution — 7 pass (adds resolve_board_free_fn_matches_context, resolve_board_unknown_errors)
  • soldr cargo clippy -p fbuild-build --all-targets -- -D warnings clean

Refs #519

🤖 Generated with Claude Code

…n::resolve_board (#519)

Add a single `resolution::resolve_board(board_id, overrides, project_dir)`
free function and route `ResolutionContext::resolve_board`,
`platform_for_board`, and the `script_runtime` board lookup through it.
Previously `script_runtime::build_script_runtime_board_config` called
`BoardConfig::from_board_id_in_project` directly, so a new resolution input
had to be re-plumbed into each consumer by hand — exactly the silent-drift
class of bug #519 tracks.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 756f2d19-e65c-4548-aa40-a5fd8fd6c15a

📥 Commits

Reviewing files that changed from the base of the PR and between 650bd89 and 63c75b1.

📒 Files selected for processing (2)
  • crates/fbuild-build/src/resolution.rs
  • crates/fbuild-build/src/script_runtime.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/519-board-resolution-funnel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit cf1b9c6 into main Jun 13, 2026
89 of 91 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 14, 2026
@zackees
zackees deleted the refactor/519-board-resolution-funnel branch October 16, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant