Skip to content

refactor(build): route compile_many platform lookup through resolution (#519) - #546

Merged
zackees merged 1 commit into
mainfrom
refactor/platform-for-board-resolution-519
Jun 13, 2026
Merged

zackees merged 1 commit into
mainfrom
refactor/platform-for-board-resolution-519

Conversation

@zackees

@zackees zackees commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds resolution::platform_for_board(board_id, project_dir) — the bare-board-id platform lookup (no [env] overrides) — plus a shared private platform_of helper that owns the single "could not determine platform for board ..." error.
  • Migrates compile_many::platform_for_board to delegate to it, deleting the duplicated from_board_id_in_project + error-format block.
  • ResolutionContext::resolve_platform now also routes through platform_of, so both build-side platform lookups share one error path.

Fourth slice of #519, building on the resolution module added in #545. No behavior change: same primitive, same error text.

Test plan

  • soldr cargo test -p fbuild-build — passes, incl. 2 new resolution::tests and the existing compile_many::tests::platform_for_board_uno_is_avr
  • soldr cargo clippy -p fbuild-build --all-targets -- -D warnings clean
  • soldr cargo fmt --all -- --check clean

🤖 Generated with Claude Code

Adds `resolution::platform_for_board(board_id, project_dir)` and a shared
`platform_of` error helper, then points `compile_many::platform_for_board`
at it. Removes the duplicated "could not determine platform" construction
so every build-side platform lookup shares one entry point. Part of #519.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 41 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9e032dc-72f4-4a1b-88d2-a4e831c5f2c7

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae8dc2 and af57f23.

📒 Files selected for processing (2)
  • crates/fbuild-build/src/compile_many.rs
  • crates/fbuild-build/src/resolution.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/platform-for-board-resolution-519

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit 2ef389f into main Jun 13, 2026
90 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 14, 2026
@zackees
zackees deleted the refactor/platform-for-board-resolution-519 branch October 16, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant