Skip to content

style(cli): rustfmt clangd_config.rs to fix broken main - #542

Merged
zackees merged 1 commit into
mainfrom
fix/rustfmt-clangd-config-main
Jun 13, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/rustfmt-clangd-config-main

Conversation

@zackees

@zackees zackees commented Jun 13, 2026 •

Copy link
Copy Markdown
Member

Summary

#539 was merged from its original commit, which skipped the follow-up rustfmt commit on the branch. As a result the Formatting check on main now fails (cargo fmt -p fbuild-cli -- --check reports diffs in clangd_config.rs).

This applies cargo fmt to restore main to green. Pure formatting, no behavior change.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor

    • Improved error message formatting for directory creation handling.
  • Tests

    • Enhanced test code readability through formatting improvements.

#539 merged the pre-rustfmt commit, so the Formatting check on main fails.
This applies `cargo fmt` to restore green.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b0fc4fd9-89e5-4502-8584-c4f8e9a819dd

📥 Commits

Reviewing files that changed from the base of the PR and between 3754c20 and 13ee6be.

📒 Files selected for processing (1)
  • crates/fbuild-cli/src/cli/clangd_config.rs

📝 Walkthrough

Walkthrough

This PR refactors error message formatting in the clangd_config module, condensing a multi-line error handler into a single-line format call and reformatting unit test JSON parsing for improved readability. No functional behavior changes.

Changes

Clangd Config Formatting

Layer / File(s) Summary
Error message and test formatting improvements
crates/fbuild-cli/src/cli/clangd_config.rs
.vscode directory creation error message is condensed to single-line format! call; unit test JSON parsing is reformatted for readability without changing inputs or assertions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • FastLED/fbuild#539: Introduces the initial clangd-config implementation, directly preceding this formatting refinement of the same module.

Poem

A rabbit hops through code so fine,
Where formatting makes logic shine,
Condensed and neat, each line so clear,
Readability brings good cheer! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: applying rustfmt formatting to clangd_config.rs to resolve a broken CI check on main.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rustfmt-clangd-config-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit 162299c into main Jun 13, 2026
89 of 90 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 14, 2026
@zackees
zackees deleted the fix/rustfmt-clangd-config-main branch October 16, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant