Skip to content

ci: bump setup-soldr v0.9.57 -> v0.9.59 - #372

Merged
zackees merged 1 commit into
mainfrom
chore/setup-soldr-0.9.59
Jun 2, 2026
Merged

zackees merged 1 commit into
mainfrom
chore/setup-soldr-0.9.59

Conversation

@zackees

@zackees zackees commented Jun 2, 2026 •

Copy link
Copy Markdown
Member

Summary

Bump zackees/setup-soldr from v0.9.57 to v0.9.59.

What's in v0.9.58–v0.9.59

  • v0.9.58 — Eviction log splits foundation-protected vs age-floor-protected counts (diagnostic).
  • v0.9.59 — PERF: drops git SHA from cargo-registry cache key (closes setup-soldr#371). Same anti-pattern fix as perf(library-select): #236 parallel BFS walker + scan memoization + tracing spans #237 did for build-cache. Production-observed: every commit's cargo-registry exact-key probe missed (only matched same-SHA retries), and the action burned ~56 MB upload bandwidth saving a new entry that no future probe could hit. After this fix, exact-key hit rate climbs to ~100% per (lockHash, digest) generation, save status flips to skipped-race for subsequent matrix jobs, and per-CI-cycle redundant uploads drop by ~50 MB × matrix-job-count.

Test plan

  • CI green
  • cargo-registry log shows HIT instead of FALLBACK on subsequent commits with same lockHash
  • Per-layer save table shows cargo-registry status flipping to skipped-race for jobs after the first save

Summary by CodeRabbit

  • Chores
    • Updated CI and build infrastructure components across multiple continuous integration workflows to ensure compatibility and access to latest improvements.

Bundles two setup-soldr versions:
- v0.9.58: split foundation vs age-floor eviction counts (diagnostic)
- v0.9.59: drop git SHA from cargo-registry exact key (closes
  setup-soldr#371). Same #237 anti-pattern fix; ~50 MB
  redundant upload saved per matrix-job per CI cycle.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 70ac17ce-0b2f-46d4-b6d1-88cd9c876842

📥 Commits

Reviewing files that changed from the base of the PR and between ebab2a1 and 504b00b.

📒 Files selected for processing (11)
  • .github/workflows/acceptance-205.yml
  • .github/workflows/bench-205.yml
  • .github/workflows/check-macos.yml
  • .github/workflows/check-ubuntu.yml
  • .github/workflows/check-windows.yml
  • .github/workflows/docs.yml
  • .github/workflows/dylint.yml
  • .github/workflows/fmt.yml
  • .github/workflows/msrv.yml
  • .github/workflows/template_build.yml
  • .github/workflows/template_native_build.yml

📝 Walkthrough

Walkthrough

This PR updates the zackees/setup-soldr GitHub Action version from v0.9.57 to v0.9.59 across all eleven CI/CD workflow files: acceptance, bench, platform checks, docs, linting, formatting, MSRV, and build templates. No workflow logic or commands are changed.

Changes

soldr Action Version Update

Layer / File(s) Summary
soldr action version bump across all workflows
.github/workflows/acceptance-205.yml, .github/workflows/bench-205.yml, .github/workflows/check-macos.yml, .github/workflows/check-ubuntu.yml, .github/workflows/check-windows.yml, .github/workflows/docs.yml, .github/workflows/dylint.yml, .github/workflows/fmt.yml, .github/workflows/msrv.yml, .github/workflows/template_build.yml, .github/workflows/template_native_build.yml
The uses: zackees/setup-soldr step in all workflows is updated from v0.9.57 to v0.9.59. No surrounding job logic, caching, build commands, or step configuration is changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • FastLED/fbuild#368: Updates the same GitHub Actions workflows by bumping zackees/setup-soldr action version in the same files (v0.9.50→v0.9.53).
  • FastLED/fbuild#369: Same kind of coordinated version bump for zackees/setup-soldr across identical workflow files.
  • FastLED/fbuild#333: Mechanically bumps the zackees/setup-soldr action version in the same set of workflow files without changing surrounding logic.

Poem

🐰 A tiny bump from point five-seven,
To point five-nine, our CI's in heaven!
soldr takes its rightful place,
All workflows updated at a steady pace.
Simple changes, tested true—
Version peace for me and you! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/setup-soldr-0.9.59

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit b38ebf3 into main Jun 2, 2026
89 of 91 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 3, 2026
@zackees
zackees deleted the chore/setup-soldr-0.9.59 branch October 16, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant