Skip to content

DO NOT MERGE: setup-soldr v0 canary 1e1ae41 - #2114

Closed
zackees wants to merge 1 commit into
mainfrom
chore/setup-soldr-v0-canary-1e1ae41
Closed

zackees wants to merge 1 commit into
mainfrom
chore/setup-soldr-v0-canary-1e1ae41

Conversation

@zackees

@zackees zackees commented Nov 20, 2026

Copy link
Copy Markdown
Member

NOT FOR MERGE. This is the exact-SHA downstream canary for promoting forge-ci/setup-soldr v0 to 1e1ae41b04c5a0b050e637d0a4d3f8cd30bfb83e. That SHA includes forge-ci/setup-soldr#686, which fixes #685's restore order: <exact>-g is now the first restore key, so the newest generation is restored instead of the bare entry (seen in fbuild Dylint run 44726574726).

Before #685, an exact build-cache hit was never re-saved, so the zccache store stayed frozen at its first writer. fbuild's main Dylint showed the result: it missed 62/33/33 units per pass on crates the commit never touched. With #685, a warm restore that still compiles something saves a -g<run_id> generation, restore prefers the newest generation, and older generations are deleted.

It repins every exact setup-soldr@9337570234850b50322e696037127fa3cf8ac703 reference, including ci/render_workflows.py, to the candidate. ci-full is applied so that both CI selected coverage and full / Full coverage run, as scripts/verify-v0-promotion.py requires. render_workflows.py --check passes, as do ci/test_fractional_workflows.py and ci/test_setup_soldr_cache_keys.py (30 passed).

This PR will be closed and its branch deleted once v0 moves.

@zackees zackees added the ci-full Run the complete release-equivalent CI matrix on this PR SHA label Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zackees

zackees commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

Canary run 44739095201 passed (selected and full coverage). v0 promotion to 1e1ae41 dispatched.

@zackees zackees closed this Nov 20, 2026
@zackees
zackees deleted the chore/setup-soldr-v0-canary-1e1ae41 branch November 20, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run the complete release-equivalent CI matrix on this PR SHA

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant