Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Member
Author
|
Canary run 44739095201 passed (selected and full coverage). v0 promotion to 1e1ae41 dispatched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT FOR MERGE. This is the exact-SHA downstream canary for promoting forge-ci/setup-soldr
v0to1e1ae41b04c5a0b050e637d0a4d3f8cd30bfb83e. That SHA includes forge-ci/setup-soldr#686, which fixes #685's restore order:<exact>-gis now the first restore key, so the newest generation is restored instead of the bare entry (seen in fbuild Dylint run 44726574726).Before #685, an exact build-cache hit was never re-saved, so the zccache store stayed frozen at its first writer. fbuild's
mainDylint showed the result: it missed 62/33/33 units per pass on crates the commit never touched. With #685, a warm restore that still compiles something saves a-g<run_id>generation, restore prefers the newest generation, and older generations are deleted.It repins every exact
setup-soldr@9337570234850b50322e696037127fa3cf8ac703reference, includingci/render_workflows.py, to the candidate.ci-fullis applied so that bothCI selected coverageandfull / Full coveragerun, asscripts/verify-v0-promotion.pyrequires.render_workflows.py --checkpasses, as doci/test_fractional_workflows.pyandci/test_setup_soldr_cache_keys.py(30 passed).This PR will be closed and its branch deleted once
v0moves.