Skip to content

2042 follow-ups: size and lib_deps warnings in the build log, decode encoded /tree/ refs, rename tasmota_platform_tag - #2074

Merged
zackees merged 4 commits into
mainfrom
fix/misc-followups-2042
Nov 18, 2026
Merged

zackees merged 4 commits into
mainfrom
fix/misc-followups-2042

Conversation

@zackees

@zackees zackees commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

The last group of #2042 (group 5: item 5 and the tasmota_platform_tag rename), plus the build-log leftovers from groups 1 and 2 and one lib_deps leftover.

Item 5: crate-scoped clippy vs workspace clippy

This doesn't reproduce on current main. PR #2059 already fixed it by enabling tracing/log workspace-wide, so fbuild-core's #[expect(clippy::cognitive_complexity)] in usb/data.rs is fulfilled no matter which crates are selected. These all exited 0 on this branch, where usb/data.rs and every Cargo.toml match main:

  • soldr cargo clippy -p <crate> --all-targets -- -D warnings for fbuild-core, fbuild-build-arm, fbuild-library, fbuild-serial, fbuild-paths, fbuild-build-engine, fbuild-build-esp, fbuild-config and fbuild-build-mcu
  • soldr cargo clippy --workspace --all-targets -- -D warnings

ci/hooks/lint.py runs ./lint <file>, which runs exactly soldr cargo clippy -p <crate> --all-targets -- -D warnings, so the hook path is the one checked above. No code change was needed.

Commits

  1. refactor(esptool): renames tasmota_platform_tag to esptool_release_platform_tag. Since fix(esptool): fall back to the pinned pioarduino release and report the source error #2063 it builds pioarduino release tags. The commit also takes "tasmota" out of the tool-esptoolpy doc comment and out of some made-up test cache paths. No behaviour change. Tests that describe the tasmota regression keep their names.
  2. refactor(build): moves the ignored-version-pin warnings (A pinned platform version is silently ignored — in platform and in platform_packages #1407) out of BuildContext::new_with_perf, which has #[expect(too_many_lines)], into log_config_warnings / log_ignored_version_pins. The platform and package tables become their own functions, which keeps the new helper under the 100-line limit. No behaviour change.
  3. fix(lib-deps): a /tree/<ref> or /archive/<ref>.zip URL whose ref is already percent-encoded (feature%2Fx) was encoded a second time (feature%252Fx). The ref taken from the URL path is now decoded first. A bad escape or a result that isn't UTF-8 is rejected like any other malformed URL. #<ref> refs are left alone.
  4. fix(build): the size and lib_deps warnings now reach the build log the CLI shows.

Fixes #2042

Tests

RED first, then GREEN:

  • fbuild-core elf_size::tests::size_info_carries_the_missing_ram_warning
  • fbuild-build-engine build_output::tests::size_report_warnings_reach_the_build_log
  • fbuild-build-engine pipeline::context::tests::skipped_lib_deps_are_warned_in_the_build_log
  • fbuild-library library::github_source::tests::percent_encoded_web_url_ref_is_decoded_once

Full suites:

  • soldr cargo test -p fbuild-core: 407 passed
  • -p fbuild-library: 361 passed
  • -p fbuild-build-engine: 591 + 1 passed

fmt --check and workspace clippy pass.

E2E

With FBUILD_DEV_MODE=1, I ran a dev build of this branch's fbuild-cli and fbuild-daemon on an uno blink whose lib_deps is https://gitlab.com/owner/somelib.git#v1.0. The CLI output (fbuild build . -e uno) shows the warning:

   0.00 ====================
   0.00 =   BUILDING uno   =
   0.00 ====================
   0.00 Board: Arduino Uno / ATMEGA328P @ 16MHz
   0.00 Memory: 31.50KB Flash, 2.00KB RAM
   0.01 Warning: ignoring lib_deps entry "https://gitlab.com/owner/somelib.git#v1.0": fbuild installs git repositories only from GitHub (as its source archive); this host would need a git clone, which fbuild does not do. Use the library's registry name, a GitHub URL, or a local path
   ...
  10.26 Flash: 960 bytes / 31.50KB (3.0%)
  10.26 RAM:   9 bytes / 2.00KB (0.4%)
build succeeded in 10.3s (flash: 960 bytes, ram: 9 bytes)

Not done

  • fbuild sync (fbuild-config/src/lib_source.rs) still records /tree/<ref> and /archive/... URLs as github with no ref. It can't call GitHubSource::parse_web_url directly, because fbuild-library depends on fbuild-config, not the other way round. The daemon's /api/ide/libraries endpoint also shares classify, so patching the CLI alone would make the two disagree. The fix is to move the URL-shape parser down into fbuild-config and have both callers use it, which means a cross-crate move and a decision about the lock-file format. The lock is audit-only, so I've left it.
  • ci13xx builds without a streamed BuildLog, so the new lib_deps warning doesn't appear there. Its parse_lib_specs call still traces it.

…tform_tag

Since #2063 the tag names a pioarduino/esptool release asset, not a
tasmota one. Also drop tasmota from the tool-esptoolpy doc comment and
from arbitrary test cache paths. No behaviour change.

Part of #2042
…ew_with_perf

Extract the #1407 ignored-version-pin warnings into
log_config_warnings / log_ignored_version_pins, with the platform and
package tables as their own functions, so the next commit can add a
config warning without growing new_with_perf (#[expect(too_many_lines)]).
No behaviour change.

Part of #2042
A /tree/<ref> or /archive/<ref>.zip lib_deps URL copied from a browser
can carry an encoded ref (feature%2Fx). archive_url() percent-encodes
each ref segment, so the ref was encoded twice (feature%252Fx) and the
download 404'd. Decode the path-derived ref before validating it; a
malformed escape or non-UTF-8 result is rejected like any malformed URL.
The #<ref> form is a literal ref and is left as is.

Part of #2042
…s in the build log

Both warnings went only through tracing::warn, so they reached the
daemon log but not the build output the CLI streams.

- SizeInfo gains ram_warning (serde-optional, omitted when None).
  from_elf_sections_with_ram sets it from ram_sections_missing, so every
  ELF-based size report (default, ESP32 DRAM set, Renesas) carries it,
  and log_size_report pushes "Warning: size report: ..." next to the
  Flash/RAM lines. The no-op fast path re-logs the stored SizeInfo the
  same way.
- library_manager::skipped_lib_dep_warnings returns the message
  parse_lib_specs already traces for every lib_deps entry it skips.
  BuildContext pushes each as "Warning: ..." beside the existing
  ignored-version-pin warnings, the established path for config
  warnings (#1407).
- The RAM-overflow warning was already in the build log
  ("Warning! The data size ...", log_size_report since #1473); the new
  build_output test pins that too.

ci13xx builds through its own recipe without a streamed BuildLog, so
it is not covered.

Fixes #2042
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zackees
zackees added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit a5e403b Nov 18, 2026
39 checks passed
@zackees
zackees deleted the fix/misc-followups-2042 branch November 18, 2026 08:14
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

chore: smaller follow-ups from the stevenmunn312-tech batch

1 participant