Skip to content

bench: point zccache at cached store - #192

Merged
zackees merged 1 commit into
bench/fastled-examplesfrom
codex/issue-151-bench-zccache-cache
Apr 22, 2026
Merged

zackees merged 1 commit into
bench/fastled-examplesfrom
codex/issue-151-bench-zccache-cache

Conversation

@zackees

@zackees zackees commented Apr 22, 2026

Copy link
Copy Markdown
Member

Summary

  • wire the setup action's zccache-store-path output into ZCCACHE_CACHE_DIR, which is the cache-root env var zccache actually reads
  • keep ZCCACHE_DIR populated for compatibility/logging, but report ZCCACHE_CACHE_DIR in cache footprint diagnostics
  • bump the benchmark cache prefix and CACHE_BUST to bench-v5 / iter5-zccache-cache-dir for a clean cold run

Investigation

The previous iter4 run added the setup output to the actions/cache path list, but the post-compile footprint still showed /home/runner/work/_temp/zccache at 4 KB. Upstream zccache uses ZCCACHE_CACHE_DIR as its cache-root override, so the workflow was caching the intended directory while zccache continued using its default store.

Fixes #151.

Verification

  • parsed .github/workflows/benchmark.yml with PyYAML and asserted the configure step, zccache-store-path, bench-v5, and iter5 cache bust are present
  • git diff --check

@coderabbitai

coderabbitai Bot commented Apr 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ddad2e96-b3e9-48ab-aca4-5848a55e2ea8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-151-bench-zccache-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit 8b23243 into bench/fastled-examples Apr 22, 2026
1 check passed
@zackees
zackees deleted the codex/issue-151-bench-zccache-cache branch October 16, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant